-
-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-109256: allocate opcode IDs for internal opcodes in their own range #109269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, in general.
test_dis
will need fixing up, of course.
As you need to fix test_dis
anyway could you make RESUME
opcode 1? If it is to have a special number, it might as well be memorable.
map_op(1, "RESUME")
next_opcode = 2
RESUME has an arg though, so I thought it should be after HAVE_ARGUMENT? Unless we want to special case it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Should save a fair bit of future churn.
Merge conflicts need fixing, obviously.
📚 Documentation preview 📚: https://cpython-previews--109269.org.readthedocs.build/