Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-109184: update traceback module doc w.r.t notes (message is no longer always at the end) #109201

Merged
merged 5 commits into from
Sep 12, 2023
Merged

gh-109184: update traceback module doc w.r.t notes (message is no longer always at the end) #109201

merged 5 commits into from
Sep 12, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Sep 9, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Sep 9, 2023
@bedevere-bot bedevere-bot mentioned this pull request Sep 9, 2023
Closed
@iritkatriel iritkatriel marked this pull request as ready for review September 9, 2023 21:12
@iritkatriel iritkatriel added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes and removed awaiting core review labels Sep 9, 2023
AlexWaygood
AlexWaygood reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few small suggestions:

Doc/library/traceback.rst Outdated Show resolved Hide resolved
Doc/library/traceback.rst Show resolved Hide resolved
Doc/library/traceback.rst Show resolved Hide resolved
iritkatriel and others added 2 commits September 12, 2023 12:07
@iritkatriel @AlexWaygood
Apply suggestions from code review
c7127e8 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@iritkatriel
add 3.11 change note
c875137
AlexWaygood
AlexWaygood approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I pushed to your branch to fix another tiny nit I spotted after looking over the docs preview; hope you don't mind ;)

@iritkatriel
Copy link
Member Author

LGTM, thanks! I pushed to your branch to fix another tiny nit I spotted after looking over the docs preview; hope you don't mind ;)

Yes, thank you!

@iritkatriel iritkatriel enabled auto-merge (squash) September 12, 2023 14:14
@iritkatriel iritkatriel enabled auto-merge (squash) September 12, 2023 14:52
@iritkatriel iritkatriel merged commit 0e76cc3 into python:main Sep 12, 2023
@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @iritkatriel, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0e76cc359ba5d5e29d7c75355d7c1bc7e817eecf 3.12

@miss-islington
Copy link
Contributor

Sorry, @iritkatriel, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0e76cc359ba5d5e29d7c75355d7c1bc7e817eecf 3.11

iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Sep 12, 2023
@iritkatriel
pythongh-109184: update traceback module doc w.r.t notes (message is …
b642280 
…no longer always at the end) (python#109201)

(cherry picked from commit 0e76cc3)
@bedevere-app
Copy link

bedevere-app bot commented Sep 12, 2023

GH-109334 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 12, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Sep 12, 2023
@iritkatriel
pythongh-109184: update traceback module doc w.r.t notes (message is …
247999f 
…no longer always at the end) (python#109201)

(cherry picked from commit 0e76cc3)
@bedevere-app
Copy link

bedevere-app bot commented Sep 12, 2023

GH-109336 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Sep 12, 2023
iritkatriel added a commit that referenced this pull request Sep 12, 2023
@iritkatriel
[3.11] gh-109184: update traceback module doc w.r.t notes (message is…
5681cd1 
… no longer always at the end) (#109201) (#109336)

gh-109184: update traceback module doc w.r.t notes (message is no longer always at the end) (#109201)

(cherry picked from commit 0e76cc3)
Yhg1s pushed a commit that referenced this pull request Sep 13, 2023
@iritkatriel
[3.12] gh-109184: update traceback module doc w.r.t notes (message is…
08bd2aa 
… no longer always at the end) (#109201) (#109334)

gh-109184: update traceback module doc w.r.t notes (message is no longer always at the end) (#109201)

(cherry picked from commit 0e76cc3)
vstinner pushed a commit to vstinner/cpython that referenced this pull request Sep 13, 2023
@iritkatriel @vstinner
pythongh-109184: update traceback module doc w.r.t notes (message is …
73e76e6 
…no longer always at the end) (python#109201)
@iritkatriel iritkatriel mentioned this pull request Oct 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees

@iritkatriel iritkatriel

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The docs of "traceback.format_exception_only" is incorrect when the Exception has notes
4 participants
@iritkatriel @miss-islington @AlexWaygood @bedevere-bot