Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.12] gh-108388: regrtest splits test_asyncio package (GH-108393) #108397

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 24, 2023

Currently, test_asyncio package is only splitted into sub-tests when
using command "./python -m test". With this change, it's also
splitted when passing it on the command line:
"./python -m test test_asyncio".

Remove the concept of "STDTESTS". Python is now mature enough to not
have to bother with that anymore. Removing STDTESTS simplify the
code.
(cherry picked from commit 174e9da)

Co-authored-by: Victor Stinner vstinner@python.org

Currently, test_asyncio package is only splitted into sub-tests when
using command "./python -m test". With this change, it's also
splitted when passing it on the command line:
"./python -m test test_asyncio".

Remove the concept of "STDTESTS". Python is now mature enough to not
have to bother with that anymore. Removing STDTESTS simplify the
code.
(cherry picked from commit 174e9da)

Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot

@vstinner
Copy link
Member

To test the feature manually:

$ ./python -m test test_asyncio --list-tests|wc -l
30

Without the fix, it displayed:

$ ./python -m test test_asyncio --list-tests|wc -l
1

@ambv ambv merged commit 9903fe1 into python:3.12 Aug 24, 2023
19 of 20 checks passed
@miss-islington miss-islington deleted the backport-174e9da-3.12 branch August 24, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants