gh-104469 : Convert _testcapi/vectorcall_limited.c to use AC by nahyeon-an · Pull Request #107857 · python/cpython

nahyeon-an · 2023-08-11T07:53:58Z

Issue: Improve the readability and maintainability of test_capi using the AC #104469

bedevere-bot · 2023-08-11T07:54:05Z

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

nahyeon-an · 2023-08-11T07:54:33Z

@corona10

corona10

lgtm!

ambv · 2023-08-11T14:22:51Z

Closing and re-opening to retrigger CLA checks. Sorry for the noise.

ghost · 2023-08-11T14:22:59Z

All commit authors signed the Contributor License Agreement.

bedevere-bot · 2023-08-12T01:05:54Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot wasm32-emscripten node (dynamic linking) 3.x has failed when building commit 2e27da1.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1056/builds/2776) and take a look at the build logs.
Check if the failure is related to this commit (2e27da1) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1056/builds/2776

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 7, done.        
remote: Counting objects:  14% (1/7)        
remote: Counting objects:  28% (2/7)        
remote: Counting objects:  42% (3/7)        
remote: Counting objects:  57% (4/7)        
remote: Counting objects:  71% (5/7)        
remote: Counting objects:  85% (6/7)        
remote: Counting objects: 100% (7/7)        
remote: Counting objects: 100% (7/7), done.        
remote: Compressing objects:  16% (1/6)        
remote: Compressing objects:  33% (2/6)        
remote: Compressing objects:  50% (3/6)        
remote: Compressing objects:  66% (4/6)        
remote: Compressing objects:  83% (5/6)        
remote: Compressing objects: 100% (6/6)        
remote: Compressing objects: 100% (6/6), done.        
remote: Total 7 (delta 1), reused 4 (delta 1), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '2e27da18952c6561f48dab706b5911135cedd7cf'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 2e27da1895 gh-104469 : Convert _testcapi/vectorcall_limited.c to use AC (gh-107857)
Switched to and reset branch 'main'

configure: ../../configure --prefix $(PWD)/target/host --with-pydebug --without-pydebug --with-emscripten-target=node --enable-wasm-dynamic-linking --disable-wasm-pthreads --build=x86_64-pc-linux-gnu --host=wasm32-unknown-emscripten --with-build-python=../build/python
configure: WARNING: using cross tools not prefixed with host triplet
mcc: error: no input files

make: make -j2 all
In file included from ../../Python/ceval.c:773:
../../Python/generated_cases.c.h:3597:37: warning: code will never be executed [-Wunreachable-code]
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                    ^
../../Python/generated_cases.c.h:3597:33: note: silence by adding parentheses to mark code as explicitly dead
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                ^
                                /* DISABLES CODE */ ( )
../../Python/generated_cases.c.h:3577:37: warning: code will never be executed [-Wunreachable-code]
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                    ^
../../Python/generated_cases.c.h:3577:33: note: silence by adding parentheses to mark code as explicitly dead
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                ^
                                /* DISABLES CODE */ ( )
../../Python/generated_cases.c.h:2254:37: warning: code will never be executed [-Wunreachable-code]
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                    ^
../../Python/generated_cases.c.h:2254:33: note: silence by adding parentheses to mark code as explicitly dead
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                ^
                                /* DISABLES CODE */ ( )
3 warnings generated.
In file included from ../../Python/executor.c:84:
../../Python/executor_cases.c.h:1516:37: warning: code will never be executed [-Wunreachable-code]
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                    ^
../../Python/executor_cases.c.h:1516:33: note: silence by adding parentheses to mark code as explicitly dead
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                ^
                                /* DISABLES CODE */ ( )
1 warning generated.
../../Python/initconfig.c:2252:27: warning: format specifies type 'wint_t' (aka 'int') but the argument has type 'wint_t' (aka 'unsigned int') [-Wformat]
    printf(usage_envvars, (wint_t)DELIM, (wint_t)DELIM, PYTHONHOMEHELP);
           ~~~~~~~~~~~~~  ^~~~~~~~~~~~~
../../Python/initconfig.c:145:18: note: format string is defined here
"PYTHONPATH   : '%lc'-separated list of directories prefixed to the\n"
                 ^~~
                 %c
../../Python/initconfig.c:2252:42: warning: format specifies type 'wint_t' (aka 'int') but the argument has type 'wint_t' (aka 'unsigned int') [-Wformat]
    printf(usage_envvars, (wint_t)DELIM, (wint_t)DELIM, PYTHONHOMEHELP);
           ~~~~~~~~~~~~~                 ^~~~~~~~~~~~~
../../Python/initconfig.c:147:58: note: format string is defined here
"PYTHONHOME   : alternate <prefix> directory (or <prefix>%lc<exec_prefix>).\n"
                                                         ^~~
                                                         %c
2 warnings generated.
../../Python/optimizer.c:382:9: warning: variable 'reserved' set but not used [-Wunused-but-set-variable]
    int reserved = 0;
        ^
1 warning generated.
../../Modules/expat/xmlparse.c:3116:9: warning: code will never be executed [-Wunreachable-code]
        parser->m_characterDataHandler(parser->m_handlerArg, parser->m_dataBuf,
        ^~~~~~
../../Modules/expat/xmlparse.c:3115:16: note: silence by adding parentheses to mark code as explicitly dead
      else if (0 && parser->m_characterDataHandler)
               ^
               /* DISABLES CODE */ ( )
../../Modules/expat/xmlparse.c:4059:9: warning: code will never be executed [-Wunreachable-code]
        parser->m_characterDataHandler(parser->m_handlerArg, parser->m_dataBuf,
        ^~~~~~
../../Modules/expat/xmlparse.c:4058:16: note: silence by adding parentheses to mark code as explicitly dead
      else if (0 && parser->m_characterDataHandler)
               ^
               /* DISABLES CODE */ ( )
../../Modules/expat/xmlparse.c:7703:11: warning: format specifies type 'int' but the argument has type 'ptrdiff_t' (aka 'long') [-Wformat]
          bytesMore, (account == XML_ACCOUNT_DIRECT) ? "DIR" : "EXP",
          ^~~~~~~~~
3 warnings generated.
../../Modules/socketmodule.c:4081:33: warning: comparison of integers of different signs: 'unsigned long' and 'long' [-Wsign-compare]
         cmsgh != NULL; cmsgh = CMSG_NXTHDR(&msg, cmsgh)) {
                                ^~~~~~~~~~~~~~~~~~~~~~~~
/opt/buildbot/.emscripten_cache/sysroot/include/sys/socket.h:356:44: note: expanded from macro 'CMSG_NXTHDR'
        __CMSG_LEN(cmsg) + sizeof(struct cmsghdr) >= __MHDR_END(mhdr) - (unsigned char *)(cmsg) \
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../Modules/socketmodule.c:4134:33: warning: comparison of integers of different signs: 'unsigned long' and 'long' [-Wsign-compare]
         cmsgh != NULL; cmsgh = CMSG_NXTHDR(&msg, cmsgh)) {
                                ^~~~~~~~~~~~~~~~~~~~~~~~
/opt/buildbot/.emscripten_cache/sysroot/include/sys/socket.h:356:44: note: expanded from macro 'CMSG_NXTHDR'
        __CMSG_LEN(cmsg) + sizeof(struct cmsghdr) >= __MHDR_END(mhdr) - (unsigned char *)(cmsg) \
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../Modules/socketmodule.c:4758:54: warning: comparison of integers of different signs: 'unsigned long' and 'long' [-Wsign-compare]
            cmsgh = (i == 0) ? CMSG_FIRSTHDR(&msg) : CMSG_NXTHDR(&msg, cmsgh);
                                                     ^~~~~~~~~~~~~~~~~~~~~~~~
/opt/buildbot/.emscripten_cache/sysroot/include/sys/socket.h:356:44: note: expanded from macro 'CMSG_NXTHDR'
        __CMSG_LEN(cmsg) + sizeof(struct cmsghdr) >= __MHDR_END(mhdr) - (unsigned char *)(cmsg) \
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3 warnings generated.
../../Modules/_sqlite/connection.c:2171:19: warning: result of comparison of constant 9223372036854775807 with expression of type 'Py_ssize_t' (aka 'long') is always false [-Wtautological-constant-out-of-range-compare]
    if (data->len > 9223372036854775807) {  // (1 << 63) - 1
        ~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~
1 warning generated.
In file included from ../../Modules/_testcapi/vectorcall_limited.c:3:
In file included from ../../Modules/_testcapi/clinic/vectorcall_limited.c.h:6:
../../Include/internal/pycore_gc.h:48:10: error: call to undeclared function 'PyObject_IS_GC'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    if (!PyObject_IS_GC(obj)) {
         ^
In file included from ../../Modules/_testcapi/vectorcall_limited.c:3:
In file included from ../../Modules/_testcapi/clinic/vectorcall_limited.c.h:7:
In file included from ../../Include/internal/pycore_runtime.h:14:
In file included from ../../Include/internal/pycore_floatobject.h:12:
../../Include/internal/pycore_unicodeobject.h:323:5: error: unknown type name '_Py_Identifier'
    _Py_Identifier *right       /* Right identifier */
    ^
../../Include/internal/pycore_unicodeobject.h:361:41: error: unknown type name '_Py_Identifier'
PyAPI_FUNC(PyObject*) _PyUnicode_FromId(_Py_Identifier*);
                                        ^
../../Include/internal/pycore_unicodeobject.h:379:8: error: unknown type name 'PyStatus'
xtern PyStatus _PyUnicode_InitGlobalObjects(PyInterpreterState *);
       ^
../../Include/internal/pycore_unicodeobject.h:380:8: error: unknown type name 'PyStatus'
xtern PyStatus _PyUnicode_InitTypes(PyInterpreterState *);
       ^
In file included from ../../Modules/_testcapi/vectorcall_limited.c:3:
In file included from ../../Modules/_testcapi/clinic/vectorcall_limited.c.h:7:
In file included from ../../Include/internal/pycore_runtime.h:14:
../../Include/internal/pycore_floatobject.h:17:8: error: unknown type name 'PyStatus'
xtern PyStatus _PyFloat_InitTypes(PyInterpreterState *);
       ^
../../Include/internal/pycore_floatobject.h:51:5: error: unknown type name 'PyFloatObject'
    PyFloatObject *free_list;
    ^
In file included from ../../Modules/_testcapi/vectorcall_limited.c:3:
In file included from ../../Modules/_testcapi/clinic/vectorcall_limited.c.h:7:
In file included from ../../Include/internal/pycore_runtime.h:16:
In file included from ../../Include/internal/pycore_global_objects.h:13:
../../Include/internal/pycore_global_strings.h:31:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_dictcomp, "<dictcomp>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:32:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_genexpr, "<genexpr>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:33:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_lambda, "<lambda>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:34:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_listcomp, "<listcomp>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:35:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_module, "<module>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:36:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_null, "<NULL>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:37:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_setcomp, "<setcomp>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:38:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_string, "<string>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:39:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_unknown, "<unknown>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:40:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(close_br, "}")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:41:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(dbl_close_br, "}}")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:42:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(dbl_open_br, "{{")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
mcc: error: 'ccache /opt/emsdk/upstream/bin/clang -target wasm32-unknown-emscripten -fignore-exceptions -mllvm -combiner-global-alias-analysis=false -mllvm -enable-emscripten-sjlj -mllvm -disable-lsr -DEMSCRIPTEN -D__EMSCRIPTEN_major__=3 -D__EMSCRIPTEN_minor__=1 -D__EMSCRIPTEN_tiny__=22 -Werror=implicit-function-declaration -I/opt/buildbot/.emscripten_cache/sysroot/include/SDL --sysroot=/opt/buildbot/.emscripten_cache/sysroot -Xclang -iwithsysroot/include/compat -fno-strict-overflow -Wsign-compare -Wunreachable-code -DNDEBUG -g3 -O3 -Wall -std=c11 -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -fvisibility=hidden -I../../Include/internal -IObjects -IInclude -IPython -I. -I../../Include -fPIC -DPy_BUILD_CORE_BUILTIN -c ../../Modules/_testcapi/vectorcall_limited.c -o Modules/_testcapi/vectorcall_limited.o' failed (returned 1)
make: *** [Makefile:3039: Modules/_testcapi/vectorcall_limited.o] Error 1
make: *** Waiting for unfinished jobs....
mmake: error: 'make -j2 all' failed (returned 2)

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make: [Makefile:2771: clean-retain-profile] Error 1 (ignored)

bedevere-bot · 2023-08-12T01:07:13Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot wasm32-wasi 3.x has failed when building commit 2e27da1.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1046/builds/2731) and take a look at the build logs.
Check if the failure is related to this commit (2e27da1) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1046/builds/2731

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 7, done.        
remote: Counting objects:  14% (1/7)        
remote: Counting objects:  28% (2/7)        
remote: Counting objects:  42% (3/7)        
remote: Counting objects:  57% (4/7)        
remote: Counting objects:  71% (5/7)        
remote: Counting objects:  85% (6/7)        
remote: Counting objects: 100% (7/7)        
remote: Counting objects: 100% (7/7), done.        
remote: Compressing objects:  16% (1/6)        
remote: Compressing objects:  33% (2/6)        
remote: Compressing objects:  50% (3/6)        
remote: Compressing objects:  66% (4/6)        
remote: Compressing objects:  83% (5/6)        
remote: Compressing objects: 100% (6/6)        
remote: Compressing objects: 100% (6/6), done.        
remote: Total 7 (delta 1), reused 5 (delta 1), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '2e27da18952c6561f48dab706b5911135cedd7cf'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 2e27da1895 gh-104469 : Convert _testcapi/vectorcall_limited.c to use AC (gh-107857)
Switched to and reset branch 'main'

configure: WARNING: using cross tools not prefixed with host triplet

In file included from ../../Python/ceval.c:773:
../../Python/generated_cases.c.h:3597:37: warning: code will never be executed [-Wunreachable-code]
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                    ^
../../Python/generated_cases.c.h:3597:33: note: silence by adding parentheses to mark code as explicitly dead
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                ^
                                /* DISABLES CODE */ ( )
../../Python/generated_cases.c.h:3577:37: warning: code will never be executed [-Wunreachable-code]
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                    ^
../../Python/generated_cases.c.h:3577:33: note: silence by adding parentheses to mark code as explicitly dead
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                ^
                                /* DISABLES CODE */ ( )
../../Python/generated_cases.c.h:2254:37: warning: code will never be executed [-Wunreachable-code]
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                    ^
../../Python/generated_cases.c.h:2254:33: note: silence by adding parentheses to mark code as explicitly dead
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                ^
                                /* DISABLES CODE */ ( )
3 warnings generated.
In file included from ../../Python/executor.c:84:
../../Python/executor_cases.c.h:1516:37: warning: code will never be executed [-Wunreachable-code]
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                    ^
../../Python/executor_cases.c.h:1516:33: note: silence by adding parentheses to mark code as explicitly dead
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                ^
                                /* DISABLES CODE */ ( )
1 warning generated.
../../Modules/expat/xmlparse.c:3116:9: warning: code will never be executed [-Wunreachable-code]
        parser->m_characterDataHandler(parser->m_handlerArg, parser->m_dataBuf,
        ^~~~~~
../../Modules/expat/xmlparse.c:3115:16: note: silence by adding parentheses to mark code as explicitly dead
      else if (0 && parser->m_characterDataHandler)
               ^
               /* DISABLES CODE */ ( )
../../Modules/expat/xmlparse.c:4059:9: warning: code will never be executed [-Wunreachable-code]
        parser->m_characterDataHandler(parser->m_handlerArg, parser->m_dataBuf,
        ^~~~~~
../../Modules/expat/xmlparse.c:4058:16: note: silence by adding parentheses to mark code as explicitly dead
      else if (0 && parser->m_characterDataHandler)
               ^
               /* DISABLES CODE */ ( )
../../Modules/expat/xmlparse.c:7703:11: warning: format specifies type 'int' but the argument has type 'ptrdiff_t' (aka 'long') [-Wformat]
          bytesMore, (account == XML_ACCOUNT_DIRECT) ? "DIR" : "EXP",
          ^~~~~~~~~
3 warnings generated.
../../Modules/posixmodule.c:7519:13: warning: unused function 'warn_about_fork_with_threads' [-Wunused-function]
static void warn_about_fork_with_threads(const char* name) {
            ^
1 warning generated.
In file included from ../../Modules/_testcapi/vectorcall_limited.c:3:
In file included from ../../Modules/_testcapi/clinic/vectorcall_limited.c.h:6:
../../Include/internal/pycore_gc.h:48:10: error: implicit declaration of function 'PyObject_IS_GC' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    if (!PyObject_IS_GC(obj)) {
         ^
In file included from ../../Modules/_testcapi/vectorcall_limited.c:3:
In file included from ../../Modules/_testcapi/clinic/vectorcall_limited.c.h:7:
In file included from ../../Include/internal/pycore_runtime.h:13:
In file included from ../../Include/internal/pycore_ceval_state.h:13:
../../Include/internal/pycore_gil.h:37:5: error: unknown type name 'pthread_cond_t'
    PyCOND_T cond;
    ^
../../Include/internal/pycore_condvar.h:28:18: note: expanded from macro 'PyCOND_T'
#define PyCOND_T pthread_cond_t
                 ^
In file included from ../../Modules/_testcapi/vectorcall_limited.c:3:
In file included from ../../Modules/_testcapi/clinic/vectorcall_limited.c.h:7:
In file included from ../../Include/internal/pycore_runtime.h:13:
In file included from ../../Include/internal/pycore_ceval_state.h:13:
../../Include/internal/pycore_gil.h:38:5: error: unknown type name 'pthread_mutex_t'
    PyMUTEX_T mutex;
    ^
../../Include/internal/pycore_condvar.h:27:19: note: expanded from macro 'PyMUTEX_T'
#define PyMUTEX_T pthread_mutex_t
                  ^
In file included from ../../Modules/_testcapi/vectorcall_limited.c:3:
In file included from ../../Modules/_testcapi/clinic/vectorcall_limited.c.h:7:
In file included from ../../Include/internal/pycore_runtime.h:13:
In file included from ../../Include/internal/pycore_ceval_state.h:13:
../../Include/internal/pycore_gil.h:42:5: error: unknown type name 'pthread_cond_t'
    PyCOND_T switch_cond;
    ^
../../Include/internal/pycore_condvar.h:28:18: note: expanded from macro 'PyCOND_T'
#define PyCOND_T pthread_cond_t
                 ^
In file included from ../../Modules/_testcapi/vectorcall_limited.c:3:
In file included from ../../Modules/_testcapi/clinic/vectorcall_limited.c.h:7:
In file included from ../../Include/internal/pycore_runtime.h:13:
In file included from ../../Include/internal/pycore_ceval_state.h:13:
../../Include/internal/pycore_gil.h:43:5: error: unknown type name 'pthread_mutex_t'
    PyMUTEX_T switch_mutex;
    ^
../../Include/internal/pycore_condvar.h:27:19: note: expanded from macro 'PyMUTEX_T'
#define PyMUTEX_T pthread_mutex_t
                  ^
In file included from ../../Modules/_testcapi/vectorcall_limited.c:3:
In file included from ../../Modules/_testcapi/clinic/vectorcall_limited.c.h:7:
In file included from ../../Include/internal/pycore_runtime.h:14:
In file included from ../../Include/internal/pycore_floatobject.h:12:
../../Include/internal/pycore_unicodeobject.h:323:5: error: unknown type name '_Py_Identifier'
    _Py_Identifier *right       /* Right identifier */
    ^
../../Include/internal/pycore_unicodeobject.h:361:41: error: unknown type name '_Py_Identifier'
PyAPI_FUNC(PyObject*) _PyUnicode_FromId(_Py_Identifier*);
                                        ^
../../Include/internal/pycore_unicodeobject.h:379:8: error: unknown type name 'PyStatus'
xtern PyStatus _PyUnicode_InitGlobalObjects(PyInterpreterState *);
       ^
../../Include/internal/pycore_unicodeobject.h:380:8: error: unknown type name 'PyStatus'
xtern PyStatus _PyUnicode_InitTypes(PyInterpreterState *);
       ^
In file included from ../../Modules/_testcapi/vectorcall_limited.c:3:
In file included from ../../Modules/_testcapi/clinic/vectorcall_limited.c.h:7:
In file included from ../../Include/internal/pycore_runtime.h:14:
../../Include/internal/pycore_floatobject.h:17:8: error: unknown type name 'PyStatus'
xtern PyStatus _PyFloat_InitTypes(PyInterpreterState *);
       ^
../../Include/internal/pycore_floatobject.h:51:5: error: unknown type name 'PyFloatObject'
    PyFloatObject *free_list;
    ^
In file included from ../../Modules/_testcapi/vectorcall_limited.c:3:
In file included from ../../Modules/_testcapi/clinic/vectorcall_limited.c.h:7:
In file included from ../../Include/internal/pycore_runtime.h:16:
In file included from ../../Include/internal/pycore_global_objects.h:13:
../../Include/internal/pycore_global_strings.h:31:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_dictcomp, "<dictcomp>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:32:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_genexpr, "<genexpr>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:33:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_lambda, "<lambda>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:34:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_listcomp, "<listcomp>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:35:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_module, "<module>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:36:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_null, "<NULL>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:37:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_setcomp, "<setcomp>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:38:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_string, "<string>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make: *** [Makefile:3014: Modules/_testcapi/vectorcall_limited.o] Error 1
make: *** Waiting for unfinished jobs....

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make: [Makefile:2764: clean-retain-profile] Error 1 (ignored)

bedevere-bot · 2023-08-12T01:09:19Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot wasm32-emscripten node (pthreads) 3.x has failed when building commit 2e27da1.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1050/builds/2763) and take a look at the build logs.
Check if the failure is related to this commit (2e27da1) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1050/builds/2763

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 7, done.        
remote: Counting objects:  14% (1/7)        
remote: Counting objects:  28% (2/7)        
remote: Counting objects:  42% (3/7)        
remote: Counting objects:  57% (4/7)        
remote: Counting objects:  71% (5/7)        
remote: Counting objects:  85% (6/7)        
remote: Counting objects: 100% (7/7)        
remote: Counting objects: 100% (7/7), done.        
remote: Compressing objects:  16% (1/6)        
remote: Compressing objects:  33% (2/6)        
remote: Compressing objects:  50% (3/6)        
remote: Compressing objects:  66% (4/6)        
remote: Compressing objects:  83% (5/6)        
remote: Compressing objects: 100% (6/6)        
remote: Compressing objects: 100% (6/6), done.        
remote: Total 7 (delta 1), reused 5 (delta 1), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '2e27da18952c6561f48dab706b5911135cedd7cf'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 2e27da1895 gh-104469 : Convert _testcapi/vectorcall_limited.c to use AC (gh-107857)
Switched to and reset branch 'main'

configure: ../../configure --prefix $(PWD)/target/host --with-pydebug --without-pydebug --with-emscripten-target=node --disable-wasm-dynamic-linking --enable-wasm-pthreads --build=x86_64-pc-linux-gnu --host=wasm32-unknown-emscripten --with-build-python=../build/python
configure: WARNING: using cross tools not prefixed with host triplet
mcc: error: no input files

make: make -j2 all
In file included from ../../Python/ceval.c:773:
../../Python/generated_cases.c.h:3597:37: warning: code will never be executed [-Wunreachable-code]
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                    ^
../../Python/generated_cases.c.h:3597:33: note: silence by adding parentheses to mark code as explicitly dead
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                ^
                                /* DISABLES CODE */ ( )
../../Python/generated_cases.c.h:3577:37: warning: code will never be executed [-Wunreachable-code]
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                    ^
../../Python/generated_cases.c.h:3577:33: note: silence by adding parentheses to mark code as explicitly dead
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                ^
                                /* DISABLES CODE */ ( )
../../Python/generated_cases.c.h:2254:37: warning: code will never be executed [-Wunreachable-code]
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                    ^
../../Python/generated_cases.c.h:2254:33: note: silence by adding parentheses to mark code as explicitly dead
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                ^
                                /* DISABLES CODE */ ( )
3 warnings generated.
In file included from ../../Python/executor.c:84:
../../Python/executor_cases.c.h:1516:37: warning: code will never be executed [-Wunreachable-code]
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                    ^
../../Python/executor_cases.c.h:1516:33: note: silence by adding parentheses to mark code as explicitly dead
            stack_pointer[-1 - (0 ? 1 : 0)] = attr;
                                ^
                                /* DISABLES CODE */ ( )
1 warning generated.
../../Python/initconfig.c:2252:27: warning: format specifies type 'wint_t' (aka 'int') but the argument has type 'wint_t' (aka 'unsigned int') [-Wformat]
    printf(usage_envvars, (wint_t)DELIM, (wint_t)DELIM, PYTHONHOMEHELP);
           ~~~~~~~~~~~~~  ^~~~~~~~~~~~~
../../Python/initconfig.c:145:18: note: format string is defined here
"PYTHONPATH   : '%lc'-separated list of directories prefixed to the\n"
                 ^~~
                 %c
../../Python/initconfig.c:2252:42: warning: format specifies type 'wint_t' (aka 'int') but the argument has type 'wint_t' (aka 'unsigned int') [-Wformat]
    printf(usage_envvars, (wint_t)DELIM, (wint_t)DELIM, PYTHONHOMEHELP);
           ~~~~~~~~~~~~~                 ^~~~~~~~~~~~~
../../Python/initconfig.c:147:58: note: format string is defined here
"PYTHONHOME   : alternate <prefix> directory (or <prefix>%lc<exec_prefix>).\n"
                                                         ^~~
                                                         %c
2 warnings generated.
../../Python/optimizer.c:382:9: warning: variable 'reserved' set but not used [-Wunused-but-set-variable]
    int reserved = 0;
        ^
1 warning generated.
../../Modules/expat/xmlparse.c:3116:9: warning: code will never be executed [-Wunreachable-code]
        parser->m_characterDataHandler(parser->m_handlerArg, parser->m_dataBuf,
        ^~~~~~
../../Modules/expat/xmlparse.c:3115:16: note: silence by adding parentheses to mark code as explicitly dead
      else if (0 && parser->m_characterDataHandler)
               ^
               /* DISABLES CODE */ ( )
../../Modules/expat/xmlparse.c:4059:9: warning: code will never be executed [-Wunreachable-code]
        parser->m_characterDataHandler(parser->m_handlerArg, parser->m_dataBuf,
        ^~~~~~
../../Modules/expat/xmlparse.c:4058:16: note: silence by adding parentheses to mark code as explicitly dead
      else if (0 && parser->m_characterDataHandler)
               ^
               /* DISABLES CODE */ ( )
../../Modules/expat/xmlparse.c:7703:11: warning: format specifies type 'int' but the argument has type 'ptrdiff_t' (aka 'long') [-Wformat]
          bytesMore, (account == XML_ACCOUNT_DIRECT) ? "DIR" : "EXP",
          ^~~~~~~~~
3 warnings generated.
../../Modules/socketmodule.c:4081:33: warning: comparison of integers of different signs: 'unsigned long' and 'long' [-Wsign-compare]
         cmsgh != NULL; cmsgh = CMSG_NXTHDR(&msg, cmsgh)) {
                                ^~~~~~~~~~~~~~~~~~~~~~~~
/opt/buildbot/.emscripten_cache/sysroot/include/sys/socket.h:356:44: note: expanded from macro 'CMSG_NXTHDR'
        __CMSG_LEN(cmsg) + sizeof(struct cmsghdr) >= __MHDR_END(mhdr) - (unsigned char *)(cmsg) \
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../Modules/socketmodule.c:4134:33: warning: comparison of integers of different signs: 'unsigned long' and 'long' [-Wsign-compare]
         cmsgh != NULL; cmsgh = CMSG_NXTHDR(&msg, cmsgh)) {
                                ^~~~~~~~~~~~~~~~~~~~~~~~
/opt/buildbot/.emscripten_cache/sysroot/include/sys/socket.h:356:44: note: expanded from macro 'CMSG_NXTHDR'
        __CMSG_LEN(cmsg) + sizeof(struct cmsghdr) >= __MHDR_END(mhdr) - (unsigned char *)(cmsg) \
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../Modules/socketmodule.c:4758:54: warning: comparison of integers of different signs: 'unsigned long' and 'long' [-Wsign-compare]
            cmsgh = (i == 0) ? CMSG_FIRSTHDR(&msg) : CMSG_NXTHDR(&msg, cmsgh);
                                                     ^~~~~~~~~~~~~~~~~~~~~~~~
/opt/buildbot/.emscripten_cache/sysroot/include/sys/socket.h:356:44: note: expanded from macro 'CMSG_NXTHDR'
        __CMSG_LEN(cmsg) + sizeof(struct cmsghdr) >= __MHDR_END(mhdr) - (unsigned char *)(cmsg) \
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3 warnings generated.
../../Modules/_sqlite/connection.c:2171:19: warning: result of comparison of constant 9223372036854775807 with expression of type 'Py_ssize_t' (aka 'long') is always false [-Wtautological-constant-out-of-range-compare]
    if (data->len > 9223372036854775807) {  // (1 << 63) - 1
        ~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~
1 warning generated.
In file included from ../../Modules/_testcapi/vectorcall_limited.c:3:
In file included from ../../Modules/_testcapi/clinic/vectorcall_limited.c.h:6:
../../Include/internal/pycore_gc.h:48:10: error: call to undeclared function 'PyObject_IS_GC'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    if (!PyObject_IS_GC(obj)) {
         ^
In file included from ../../Modules/_testcapi/vectorcall_limited.c:3:
In file included from ../../Modules/_testcapi/clinic/vectorcall_limited.c.h:7:
In file included from ../../Include/internal/pycore_runtime.h:14:
In file included from ../../Include/internal/pycore_floatobject.h:12:
../../Include/internal/pycore_unicodeobject.h:323:5: error: unknown type name '_Py_Identifier'
    _Py_Identifier *right       /* Right identifier */
    ^
../../Include/internal/pycore_unicodeobject.h:361:41: error: unknown type name '_Py_Identifier'
PyAPI_FUNC(PyObject*) _PyUnicode_FromId(_Py_Identifier*);
                                        ^
../../Include/internal/pycore_unicodeobject.h:379:8: error: unknown type name 'PyStatus'
xtern PyStatus _PyUnicode_InitGlobalObjects(PyInterpreterState *);
       ^
../../Include/internal/pycore_unicodeobject.h:380:8: error: unknown type name 'PyStatus'
xtern PyStatus _PyUnicode_InitTypes(PyInterpreterState *);
       ^
In file included from ../../Modules/_testcapi/vectorcall_limited.c:3:
In file included from ../../Modules/_testcapi/clinic/vectorcall_limited.c.h:7:
In file included from ../../Include/internal/pycore_runtime.h:14:
../../Include/internal/pycore_floatobject.h:17:8: error: unknown type name 'PyStatus'
xtern PyStatus _PyFloat_InitTypes(PyInterpreterState *);
       ^
../../Include/internal/pycore_floatobject.h:51:5: error: unknown type name 'PyFloatObject'
    PyFloatObject *free_list;
    ^
In file included from ../../Modules/_testcapi/vectorcall_limited.c:3:
In file included from ../../Modules/_testcapi/clinic/vectorcall_limited.c.h:7:
In file included from ../../Include/internal/pycore_runtime.h:16:
In file included from ../../Include/internal/pycore_global_objects.h:13:
../../Include/internal/pycore_global_strings.h:31:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_dictcomp, "<dictcomp>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:32:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_genexpr, "<genexpr>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:33:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_lambda, "<lambda>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:34:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_listcomp, "<listcomp>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:35:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_module, "<module>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:36:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_null, "<NULL>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:37:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_setcomp, "<setcomp>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:38:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_string, "<string>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:39:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(anon_unknown, "<unknown>")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:40:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(close_br, "}")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:41:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(dbl_close_br, "}}")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
../../Include/internal/pycore_global_strings.h:42:9: error: unknown type name 'PyASCIIObject'
        STRUCT_FOR_STR(dbl_open_br, "{{")
        ^
../../Include/internal/pycore_global_strings.h:22:5: note: expanded from macro 'STRUCT_FOR_STR'
    STRUCT_FOR_ASCII_STR(LITERAL) _py_ ## NAME;
    ^
../../Include/internal/pycore_global_strings.h:18:9: note: expanded from macro 'STRUCT_FOR_ASCII_STR'
        PyASCIIObject _ascii; \
        ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
mcc: error: 'ccache /opt/emsdk/upstream/bin/clang -target wasm32-unknown-emscripten -fignore-exceptions -mllvm -combiner-global-alias-analysis=false -mllvm -enable-emscripten-sjlj -mllvm -disable-lsr -D__EMSCRIPTEN_SHARED_MEMORY__=1 -DEMSCRIPTEN -D__EMSCRIPTEN_major__=3 -D__EMSCRIPTEN_minor__=1 -D__EMSCRIPTEN_tiny__=22 -Werror=implicit-function-declaration -I/opt/buildbot/.emscripten_cache/sysroot/include/SDL --sysroot=/opt/buildbot/.emscripten_cache/sysroot -Xclang -iwithsysroot/include/compat -fno-strict-overflow -Wsign-compare -Wunreachable-code -DNDEBUG -g3 -O3 -Wall -pthread -std=c11 -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -fvisibility=hidden -I../../Include/internal -IObjects -IInclude -IPython -I. -I../../Include -DPy_BUILD_CORE_BUILTIN -c -matomics -mbulk-memory ../../Modules/_testcapi/vectorcall_limited.c -o Modules/_testcapi/vectorcall_limited.o' failed (returned 1)
make: *** [Makefile:3038: Modules/_testcapi/vectorcall_limited.o] Error 1
make: *** Waiting for unfinished jobs....
mmake: error: 'make -j2 all' failed (returned 2)

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make: [Makefile:2770: clean-retain-profile] Error 1 (ignored)

brettcannon · 2023-08-14T22:07:33Z

@corona10 FYI this caused a few of the WebAssembly buildbots to fail, e.g., https://buildbot.python.org/all/#/builders/1046/builds/2731 .

corona10 · 2023-08-14T22:11:09Z

@corona10 FYI this caused a few of the WebAssembly buildbots to fail, e.g., https://buildbot.python.org/all/#/builders/1046/builds/2731 .

I will take a look, it can be easily fixed if the implicit function declarations is a real issue.

In file included from ../../Modules/_testcapi/clinic/vectorcall_limited.c.h:6:
../../Include/internal/pycore_gc.h:48:10: error: call to undeclared function 'PyObject_IS_GC'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if (!PyObject_IS_GC(obj)) {

corona10 · 2023-08-14T22:38:56Z

#define Py_LIMITED_API 0x030c0000 // 3.12
#include "parts.h"
#include "clinic/vectorcall_limited.c.h"

#ifdef LIMITED_API_AVAILABLE

~~the code line of #ifdef LIMITED_API_AVAILABLE was issue, I will send a hot fix for it.~~

corona10 · 2023-08-14T22:43:51Z

Okay, this is an issue between AC and limited C APIs. We should revert it first.
cc @erlend-aasland @vstinner @nahyeon-an

Thank you @vstinner for investigation :)

…se AC (pythongh-107857)" This reverts commit 2e27da1.

vstinner · 2023-08-14T22:52:55Z

Okay, this is an issue between AC and limited C APIs

Right, see:

gh-107951) Revert "gh-104469 : Convert _testcapi/vectorcall_limited.c to use AC (gh-107857)" This reverts commit 2e27da1.

erlend-aasland · 2023-08-15T05:08:56Z

Sounds good, go ahead with any needed reverts. It is not important that the _test* extension modules use clinic :)

…se AC … (pythongh-107951) Revert "pythongh-104469 : Convert _testcapi/vectorcall_limited.c to use AC (pythongh-107857)" This reverts commit 2e27da1.

vstinner · 2023-09-21T20:09:21Z

New attempt since Argument Clinic now supports the limited C API: PR #109691.

vstinner · 2023-09-25T11:25:06Z

@nahyeon-an: I merged again your PR as 8c521f0 (PR gh-109691). Thanks for your contribution!

Convert _testcapi/vectorcall_limited.c to use AC

e32cb50

bedevere-bot added the awaiting review label Aug 11, 2023

bedevere-bot mentioned this pull request Aug 11, 2023

Improve the readability and maintainability of test_capi using the AC #104469

Closed

corona10 self-assigned this Aug 11, 2023

corona10 added the skip news label Aug 11, 2023

corona10 approved these changes Aug 11, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Aug 11, 2023

corona10 enabled auto-merge (squash) August 11, 2023 07:59

ambv closed this Aug 11, 2023

auto-merge was automatically disabled August 11, 2023 14:22
Pull request was closed

ambv reopened this Aug 11, 2023

corona10 merged commit 2e27da1 into python:main Aug 12, 2023

bedevere-bot removed the awaiting merge label Aug 12, 2023

corona10 mentioned this pull request Aug 14, 2023

Revert "gh-104469 : Convert _testcapi/vectorcall_limited.c to use AC … #107951

Merged

corona10 added a commit to corona10/cpython that referenced this pull request Aug 14, 2023

Revert "pythongh-104469 : Convert _testcapi/vectorcall_limited.c to u…

95e9fb6

…se AC (pythongh-107857)" This reverts commit 2e27da1.

corona10 added a commit to corona10/cpython that referenced this pull request Aug 14, 2023

Revert "pythongh-104469 : Convert _testcapi/vectorcall_limited.c to u…

26ba468

…se AC (pythongh-107857)" This reverts commit 2e27da1.

corona10 added a commit that referenced this pull request Aug 14, 2023

Revert "gh-104469 : Convert _testcapi/vectorcall_limited.c to use AC … (

580f357

gh-107951) Revert "gh-104469 : Convert _testcapi/vectorcall_limited.c to use AC (gh-107857)" This reverts commit 2e27da1.

vstinner mentioned this pull request Sep 21, 2023

gh-104469: Disallow using Py_LIMITED_API with Py_BUILD_CORE #109690

Merged

Uh oh!

Conversation

nahyeon-an commented Aug 11, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Aug 11, 2023

Uh oh!

nahyeon-an commented Aug 11, 2023

Uh oh!

corona10 left a comment

Choose a reason for hiding this comment

Uh oh!

ambv commented Aug 11, 2023

Uh oh!

ghost commented Aug 11, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Aug 12, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Aug 12, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Aug 12, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

brettcannon commented Aug 14, 2023

Uh oh!

corona10 commented Aug 14, 2023

Uh oh!

corona10 commented Aug 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

corona10 commented Aug 14, 2023

Uh oh!

vstinner commented Aug 14, 2023

Uh oh!

erlend-aasland commented Aug 15, 2023

Uh oh!

vstinner commented Sep 21, 2023

Uh oh!

vstinner commented Sep 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nahyeon-an commented Aug 11, 2023 •

edited by bedevere-bot

Loading

ghost commented Aug 11, 2023 •

edited by ghost

Loading

corona10 commented Aug 14, 2023 •

edited

Loading