Skip to content

gh-106989: Remove tok report warnings #106993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2023
Merged

gh-106989: Remove tok report warnings #106993

merged 2 commits into from
Jul 22, 2023

Conversation

@menkotoglou
Copy link
Contributor

@menkotoglou menkotoglou commented Jul 22, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jul 22, 2023
Closed
@bedevere-bot
Copy link

bedevere-bot commented Jul 22, 2023

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost
Copy link

ghost commented Jul 22, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

lysnikolaou
lysnikolaou approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lysnikolaou lysnikolaou added the needs backport to 3.12 only security fixes label Jul 22, 2023
@lysnikolaou lysnikolaou enabled auto-merge (squash) July 22, 2023 10:34
@lysnikolaou lysnikolaou disabled auto-merge July 22, 2023 10:35
@pablogsal pablogsal merged commit 76e20c3 into python:main Jul 22, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jul 22, 2023

Thanks @menkotoglou for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2023
@menkotoglou @miss-islington
pythongh-106989: Remove tok report warnings (pythonGH-106993)
d72e981 
(cherry picked from commit 76e20c3)

Co-authored-by: Menelaos Kotoglou <contact@menelaoskotoglou.com>
@bedevere-bot
Copy link

bedevere-bot commented Jul 22, 2023

GH-107013 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 22, 2023
pablogsal pushed a commit that referenced this pull request Jul 22, 2023
@miss-islington @menkotoglou
[3.12] gh-106989: Remove tok report warnings (GH-106993) (#107013)
b6ace75 
Co-authored-by: Menelaos Kotoglou <contact@menelaoskotoglou.com>
@menkotoglou menkotoglou deleted the remove_tok_report_warnings branch July 22, 2023 15:51
@lysnikolaou lysnikolaou mentioned this pull request Aug 15, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@menkotoglou @bedevere-bot @miss-islington @lysnikolaou @pablogsal