Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-104050: Partially annotate Argument Clinic CLanguage class #106437

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 4, 2023

Saving render_option_group_parsing() and output_templates() methods for later

Tools/clinic/clinic.py Outdated Show resolved Hide resolved
@erlend-aasland erlend-aasland enabled auto-merge (squash) July 4, 2023 22:41
@erlend-aasland erlend-aasland merged commit 7bb9fa5 into python:main Jul 4, 2023
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 macOS 3.x has failed when building commit 7bb9fa5.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/366/builds/4739) and take a look at the build logs.
  4. Check if the failure is related to this commit (7bb9fa5) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/366/builds/4739

Failed tests:

  • test_unittest

Failed subtests:

  • test_wait_until_any_call_with_positional - test.test_unittest.testmock.testthreadingmock.TestThreadingMock.test_wait_until_any_call_with_positional

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

423 tests OK.

10 slowest tests:

  • test_math: 5 min 10 sec
  • test_multiprocessing_spawn: 4 min
  • test_signal: 3 min 52 sec
  • test_concurrent_futures: 3 min 5 sec
  • test_multiprocessing_forkserver: 2 min 10 sec
  • test_capi: 1 min 49 sec
  • test_tokenize: 1 min 49 sec
  • test_unparse: 1 min 32 sec
  • test_tarfile: 1 min 20 sec
  • test_unicodedata: 1 min 20 sec

1 test failed:
test_unittest

22 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_epoll
test_gdb test_idle test_ioctl test_launcher
test_multiprocessing_fork test_perf_profiler test_perfmaps
test_startfile test_tcl test_tkinter test_ttk test_ttk_textonly
test_turtle test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

1 re-run test:
test_unittest

Total duration: 29 min 59 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/test/test_unittest/testmock/testthreadingmock.py", line 177, in test_wait_until_any_call_with_positional
    self.assertIn(call(2), something.method_1.mock_calls)
AssertionError: call(2) not found in [call(1), call(3)]


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/test/test_unittest/testmock/testthreadingmock.py", line 173, in test_wait_until_any_call_with_positional
    self.assertNotIn(call(2), something.method_1.mock_calls)
AssertionError: call(2) unexpectedly found in [call(2), call(1)]

@erlend-aasland erlend-aasland deleted the clinic/annotate-clanguage branch July 5, 2023 06:58
carljm added a commit to carljm/cpython that referenced this pull request Jul 5, 2023
* main: (39 commits)
  pythongh-102542 Remove unused bytes object and bytes slicing (python#106433)
  Clarify state of CancelledError in doc (python#106453)
  pythongh-64595: Fix regression in file write logic in Argument Clinic (python#106449)
  pythongh-104683: Rename Lib/test/clinic.test as Lib/test/clinic.test.c (python#106443)
  tp_flags docs: fix indentation (python#106420)
  pythongh-104050: Partially annotate Argument Clinic CLanguage class (python#106437)
  pythongh-106368: Add tests for formatting helpers in Argument Clinic (python#106415)
  pythongh-104050: Annotate Argument Clinic parameter permutation helpers (python#106431)
  pythongh-104050: Annotate toplevel functions in clinic.py (python#106435)
  pythongh-106320: Fix specialize.c compilation by including pycore_pylifecycle.h (python#106434)
  Add some codeowners for `Tools/clinic/` (python#106430)
  pythongh-106217: Truncate the issue body size of `new-bugs-announce-notifier` (python#106423)
  pythongh-61215: Rename `wait_until_any_call` to `wait_until_any_call_with` (python#106414)
  pythongh-106162: array: suppress warning in test_array (python#106404)
  pythongh-106320: Remove _PyInterpreterState_HasFeature() (python#106425)
  pythonGH-106360: Support very basic superblock introspection (python#106422)
  pythongh-106406: Fix _Py_IsInterpreterFinalizing() in _winapi.c (python#106408)
  pythongh-106396: Special-case empty format spec to gen empty JoinedStr node (python#106401)
  pythongh-106368: Add tests for permutation helpers in Argument Clinic (python#106407)
  pythonGH-106008: Fix refleak when peepholing `None` comparisons (python#106367)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants