GH-89812: Make symlink support configurable in pathlib tests.#106060
GH-89812: Make symlink support configurable in pathlib tests.#106060barneygale merged 2 commits intopython:mainfrom
Conversation
Adjust the pathlib tests to add a new `PathTest.can_symlink` class attribute, which allows us to enable or disable symlink support in tests. A (near-)future commit will add an `AbstractPath` class; its tests will hard-code the value to `True` or `False` depending on a stub subclass's capabilities.
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
Not an expert, but the change seems reasonable, motivated and straightforward to me, and I didn't spot any obvious issues with the implementation reading through it.
|
You might want to consider running against the buildbot fleet if you thing there's a chance this might trigger any behavior difference on different platforms, given the previous platform dependent code (special casing windows). |
Good idea! How do I do that? :) |
barneygale
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @barneygale for commit f9bdd3a 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
3 participants
Adjust the pathlib tests to add a new
PathTest.can_symlinkclass attribute, which allows us to enable or disable symlink support in tests. A (near-)future commit will add anAbstractPathclass; its tests will hard-code the value toTrueorFalsedepending on a stub subclass's capabilities.