Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-105915: Fix SyntaxWarning becoming a SyntaxError with -We in test_fstring #105943

Merged
merged 1 commit into from
Jun 20, 2023
Merged

gh-105915: Fix SyntaxWarning becoming a SyntaxError with -We in test_fstring #105943

merged 1 commit into from
Jun 20, 2023

Conversation

lysnikolaou
Copy link
Contributor

@lysnikolaou lysnikolaou commented Jun 20, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 20, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 20, 2023
Closed
AlexWaygood
AlexWaygood approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this fixes things -- thank you!

@lysnikolaou lysnikolaou merged commit 6e40ee6 into python:main Jun 20, 2023
@miss-islington
Copy link
Contributor

Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-105945 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 20, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2023
@lysnikolaou @miss-islington
pythongh-105915: Fix SyntaxWarning becoming a SyntaxError with -We in…
d13be4d 
… test_fstring (pythonGH-105943)

(cherry picked from commit 6e40ee6)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
lysnikolaou added a commit that referenced this pull request Jun 20, 2023
@miss-islington @lysnikolaou
[3.12] gh-105915: Fix SyntaxWarning becoming a SyntaxError with -We i…
c5c8111 
…n test_fstring (GH-105943) (#105945)

(cherry picked from commit 6e40ee6)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lysnikolaou @miss-islington @bedevere-bot @AlexWaygood