Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-105509: Simplify the implementation of typing.Annotated #105510

Merged
merged 4 commits into from
Sep 1, 2023
Merged

gh-105509: Simplify the implementation of typing.Annotated #105510

merged 4 commits into from
Sep 1, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jun 8, 2023 •
edited by bedevere-bot
Loading

@AlexWaygood AlexWaygood changed the title Simplify the implementation of typing.Annotated gh-105509: Simplify the implementation of typing.Annotated Jun 8, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 8, 2023
Closed
@AlexWaygood @JelleZijlstra
Update Misc/NEWS.d/next/Library/2023-06-08-15-56-45.gh-issue-105509.Y…
2e00210 
…IG57j.rst

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@hugovk hugovk mentioned this pull request Jun 8, 2023
Closed
sobolevn
sobolevn reviewed Jun 8, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick note: right now it is possible to use Annotated in isinstance(1, typing.Annotated). However, it does not make much sense anyway:

>>> isinstance(typing.Annotated[int, 1], typing.Annotated)
False

With this patch applied it will raise a TypeError.

I don't think that it is a big deal.

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Jun 8, 2023 •
edited
Loading

Yeah. You can think up ways that this could break people's code, if they're doing strange things with typing at runtime (and as such, I definitely don't think it should be backported). But I don't think we're changing anything about the public API for this symbol here, so nothing about the contract is being broken.

hauntsaninja
hauntsaninja approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Couldn't find any isinstance(..., Annotated) in a quick search

@hauntsaninja hauntsaninja merged commit a1cbace into python:main Sep 1, 2023
@AlexWaygood AlexWaygood deleted the refactor-annotated branch September 1, 2023 21:07
@Fatal1ty Fatal1ty mentioned this pull request Apr 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@sobolevn sobolevn sobolevn left review comments

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
topic-typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify the implementation of typing.Annotated
5 participants
@AlexWaygood @JelleZijlstra @sobolevn @hauntsaninja @bedevere-bot