Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-80480: array: Add 'w' typecode. #105242

Merged
merged 10 commits into from
Jun 4, 2023
Merged

gh-80480: array: Add 'w' typecode. #105242

merged 10 commits into from
Jun 4, 2023

Conversation

methane
Copy link
Member

@methane methane commented Jun 2, 2023 •
edited by github-actions bot
Loading

@methane methane added the extension-modules C modules in the Modules dir label Jun 2, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 2, 2023
Closed
@methane methane changed the title gh-80480: array: Array 'w' typecode. gh-80480: array: Add 'w' typecode. Jun 3, 2023
@methane methane requested a review from hugovk June 4, 2023 07:06
hugovk
hugovk reviewed Jun 4, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Looks good, one comment about docs, and I don't write much C nowadays so it would be good for someone else to also review over the C changes.

@methane methane enabled auto-merge (squash) June 4, 2023 16:30
@methane methane merged commit 1237fb6 into python:main Jun 4, 2023
@methane methane deleted the array-w branch June 4, 2023 16:45
@hugovk hugovk mentioned this pull request Jun 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

Assignees
No one assigned
Labels
extension-modules C modules in the Modules dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@methane @hugovk @bedevere-bot