Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104050: Add basic type hints to Argument Clinic clinic class #104705

Merged
merged 4 commits into from
May 21, 2023
Merged

gh-104050: Add basic type hints to Argument Clinic clinic class #104705

merged 4 commits into from
May 21, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 20, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 20, 2023
Closed
AlexWaygood
AlexWaygood reviewed May 21, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some readability nits, and a few places where (if mypy doesn't complain about it), you could possibly make the annotations more precise (but those can all wait for now, if necessary)

Tools/clinic/clinic.py Outdated Show resolved Hide resolved
Tools/clinic/clinic.py Outdated Show resolved Hide resolved
Tools/clinic/clinic.py Show resolved Hide resolved
Tools/clinic/clinic.py Show resolved Hide resolved
Tools/clinic/clinic.py Outdated Show resolved Hide resolved
Tools/clinic/clinic.py Outdated Show resolved Hide resolved
AlexWaygood
AlexWaygood approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@erlend-aasland
Copy link
Contributor Author

Thanks!

Likewise! I'll look thrice before opening my next PRs, so you (hopefully) won't have to pick on basic stuff again :)

@erlend-aasland erlend-aasland enabled auto-merge (squash) May 21, 2023 20:28
@AlexWaygood
Copy link
Member

Thanks!

Likewise! I'll look thrice before opening my next PRs, so you (hopefully) won't have to pick on basic stuff again :)

Hey, typing is hard, no sweat! I still make mistakes all the time :)

@erlend-aasland erlend-aasland merged commit bf6dd8f into python:main May 21, 2023
@erlend-aasland erlend-aasland deleted the typed-clinic/clinic branch May 21, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-aasland @AlexWaygood @bedevere-bot