Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104472: Skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled #104667

Merged
merged 2 commits into from
May 19, 2023
Merged

gh-104472: Skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled #104667

merged 2 commits into from
May 19, 2023

Conversation

chgnrdv
Copy link
Contributor

@chgnrdv chgnrdv commented May 19, 2023 •
edited by bedevere-bot
Loading

@chgnrdv chgnrdv requested a review from gpshead as a code owner May 19, 2023 18:16
@bedevere-bot bedevere-bot mentioned this pull request May 19, 2023
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label May 19, 2023
@gpshead gpshead enabled auto-merge (squash) May 19, 2023 19:00
@gpshead gpshead added needs backport to 3.11 only security fixes needs backport to 3.10 only security fixes labels May 19, 2023
@gpshead gpshead merged commit c3f43bf into python:main May 19, 2023
@miss-islington
Copy link
Contributor

Thanks @chgnrdv for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @chgnrdv and @gpshead, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker c3f43bfb4bec39ff8f2c36d861a3c3a243bcb3af 3.11

@bedevere-bot
Copy link

GH-104669 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 19, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2023
@chgnrdv @miss-islington
pythongh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env…
7ba3f68 
…` if ASAN is enabled (pythonGH-104667)

Skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled.
(cherry picked from commit c3f43bf)

Co-authored-by: chgnrdv <52372310+chgnrdv@users.noreply.github.com>
@gpshead gpshead added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels May 19, 2023
@miss-islington
Copy link
Contributor

Thanks @chgnrdv for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-104673 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 19, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2023
@chgnrdv @miss-islington
pythongh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env…
6b2fd93 
…` if ASAN is enabled (pythonGH-104667)

Skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled.
(cherry picked from commit c3f43bf)

Co-authored-by: chgnrdv <52372310+chgnrdv@users.noreply.github.com>
gpshead pushed a commit that referenced this pull request May 19, 2023
@miss-islington @chgnrdv
[3.10] gh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_en…
f9d2a10 
…v` if ASAN is enabled (GH-104667) (#104669)

gh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env` if ASAN is enabled (GH-104667)

Skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled.
(cherry picked from commit c3f43bf)

Co-authored-by: chgnrdv <52372310+chgnrdv@users.noreply.github.com>
gpshead pushed a commit that referenced this pull request May 19, 2023
@miss-islington @chgnrdv
[3.11] gh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_en…
2801b3f 
…v` if ASAN is enabled (GH-104667) (#104673)

gh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env` if ASAN is enabled (GH-104667)

Skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled.
(cherry picked from commit c3f43bf)

Co-authored-by: chgnrdv <52372310+chgnrdv@users.noreply.github.com>
carljm added a commit to gsallam/cpython_with_perfmap_apii that referenced this pull request May 20, 2023
@carljm
Merge branch 'main' into gsallam/main
ea5965a 
* main: (30 commits)
  pythongh-103987: fix several crashes in mmap module (python#103990)
  docs: fix wrong indentation causing rendering error in dis page (python#104661)
  pythongh-94906: Support multiple steps in math.nextafter (python#103881)
  pythongh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env` if ASAN is enabled (python#104667)
  pythongh-103839: Allow building Tkinter against Tcl 8.7 without external libtommath (pythonGH-103842)
  pythongh-85984: New additions and improvements to the tty library. (python#101832)
  pythongh-104659: Consolidate python examples in enum documentation (python#104665)
  pythongh-92248: Deprecate `type`, `choices`, `metavar` parameters of `argparse.BooleanOptionalAction` (python#103678)
  pythongh-104645: fix error handling in marshal tests (python#104646)
  pythongh-104600: Make type.__type_params__ writable (python#104634)
  pythongh-104602: Add additional test for listcomp with lambda (python#104639)
  pythongh-104640: Disallow walrus in comprehension within type scopes (python#104641)
  pythongh-103921: Rename "type" header in argparse docs (python#104654)
  Improve readability of `typing._ProtocolMeta.__instancecheck__` (python#104649)
  pythongh-96522: Fix deadlock in pty.spawn (python#96639)
  pythonGH-102818: Do not call `PyTraceBack_Here` in sys.settrace trampoline.  (pythonGH-104579)
  pythonGH-103545: Add macOS specific constants for ``os.setpriority`` to ``os`` (python#104606)
  pythongh-104623: Update macOS installer to SQLite 3.42.0 (pythonGH-104624)
  pythongh-104619: never leak comprehension locals to outer locals() (python#104637)
  pythongh-104602: ensure all cellvars are known up front (python#104603)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

@sunmy2019 sunmy2019 sunmy2019 approved these changes

Assignees

@gpshead gpshead

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ASAN failure was detected while running test_threading
5 participants
@chgnrdv @miss-islington @bedevere-bot @gpshead @sunmy2019