GH-104102: Optimize pathlib.Path.glob() handling of ../ pattern segments#104103
Merged
barneygale merged 4 commits intopython:mainfrom May 2, 2023
Merged
GH-104102: Optimize pathlib.Path.glob() handling of ../ pattern segments#104103barneygale merged 4 commits intopython:mainfrom
pathlib.Path.glob() handling of ../ pattern segments#104103barneygale merged 4 commits intopython:mainfrom
Conversation
These segments do not require a `stat()` call, as the selector's `_select_from()` method is called after we've established that the parent is a directory.
barneygale
changed the title
pathlib.Path.glob() handling of ../ pattern segmentspathlib.Path.glob() handling of ../ pattern segments
AlexWaygood
reviewed
May 2, 2023
Member
|
I think we could add some more tests here. There don't seem to be any tests for patterns with two successive |
AlexWaygood
approved these changes
May 2, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Looks fab to me other than my point about test coverage! Great work.
AlexWaygood
added
type-feature
Contributor
Author
|
Thank you Alex! |
carljm
added a commit
to carljm/cpython
that referenced
this pull request
May 2, 2023
* main: (760 commits) pythonGH-104102: Optimize `pathlib.Path.glob()` handling of `../` pattern segments (pythonGH-104103) pythonGH-104104: Optimize `pathlib.Path.glob()` by avoiding repeated calls to `os.path.normcase()` (pythonGH-104105) pythongh-103822: [Calendar] change return value to enum for day and month APIs (pythonGH-103827) pythongh-65022: Fix description of tuple return value in copyreg (python#103892) pythonGH-103525: Improve exception message from `pathlib.PurePath()` (pythonGH-103526) pythongh-84436: Add integration C API tests for immortal objects (pythongh-103962) pythongh-103743: Add PyUnstable_Object_GC_NewWithExtraData (pythonGH-103744) pythongh-102997: Update Windows installer to SQLite 3.41.2. (python#102999) pythonGH-103484: Fix redirected permanently URLs (python#104001) Improve assert_type phrasing (python#104081) pythongh-102997: Update macOS installer to SQLite 3.41.2. (pythonGH-102998) pythonGH-103472: close response in HTTPConnection._tunnel (python#103473) pythongh-88496: IDLE - fix another test on macOS (python#104075) pythongh-94673: Hide Objects in PyTypeObject Behind Accessors (pythongh-104074) pythongh-94673: Properly Initialize and Finalize Static Builtin Types for Each Interpreter (pythongh-104072) pythongh-104016: Skip test for deeply neste f-strings on wasi (python#104071) pythongh-104057: Fix direct invocation of test_super (python#104064) pythongh-87092: Expose assembler to unit tests (python#103988) pythongh-97696: asyncio eager tasks factory (python#102853) pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These segments do not require a
stat()call, as the selector's_select_from()method is called after we've established that the parent is a directory.This PR adds a new
_ParentSelectorclass, which is used to evaluate../segments rather than_PreciseSelector.pathlib.Path.glob()handling of../pattern segments #104102