Skip to content

gh-103978: avoid using 'class' as an identifier #103979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2023
Merged

gh-103978: avoid using 'class' as an identifier #103979

merged 2 commits into from
Apr 28, 2023

Conversation

carljm
Copy link
Member

@carljm carljm commented Apr 28, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Apr 28, 2023
Closed
@carljm carljm mentioned this pull request Apr 28, 2023
Merged
brandtbucher
brandtbucher approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, super minor... but maybe use cls instead of klass for this?

It's a much more common name in our codebase... and I personally like it a lot more. 🙃

@carljm carljm enabled auto-merge (squash) April 28, 2023 18:51
@carljm carljm merged commit ebf97c5 into python:main Apr 28, 2023
@carljm carljm deleted the fixclass branch April 28, 2023 19:21
@tacaswell
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'class' parameter name in headers breaks building C++ extensions
5 participants
@carljm @tacaswell @JelleZijlstra @brandtbucher @bedevere-bot