gh-100227: Make the Global PyModuleDef Cache Safe for Isolated Interpreters#102938
Closed
ericsnowcurrently wants to merge 23 commits intopython:mainfrom
Closed
gh-100227: Make the Global PyModuleDef Cache Safe for Isolated Interpreters#102938ericsnowcurrently wants to merge 23 commits intopython:mainfrom
ericsnowcurrently wants to merge 23 commits intopython:mainfrom
Conversation
ericsnowcurrently
requested review from
brettcannon,
encukou,
ncoghlan and
warsaw
as code owners
Member
Author
|
I'm closing this in favor of gh-103084. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a similar change to gh-102925, but applied to the global cache of
PyModuleDefs instead of the interned strings. Note that the cache is only used for legacy extension modules and not for multi-phase init modules.(Until gh-102925 is merged, this is based on top of it.)