Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Simplify Copyright line in README #10287

Merged
merged 1 commit into from
Nov 10, 2018
Merged

Conversation

davidak
Copy link
Contributor

@davidak davidak commented Nov 1, 2018

This also makes it consistent with other places like:

This also makes it consistent with other places like:

- https://docs.python.org/dev/copyright.html
- https://www.python.org/ footer
- https://github.com/python/cpython/blob/e42b705188271da108de42b55d9344642170aa2b/Python/getcopyright.c#L7

This is my first contribution to python, completely done using GitHubs webinterface. I will sign the CLA later today.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@matrixise
Copy link
Member

For me, it's ok, we have some references where the copyright by the PSF is from 2001-2018. We could merge it after the review of @VanL .

@VanL
Copy link
Member

VanL commented Nov 7, 2018

This is fine with me.

@Mariatta
Copy link
Member

Mariatta commented Nov 8, 2018

I beleieve there is an issue in bpo about the copyright. I'll have to look it up and link it here.

@ned-deily
Copy link
Member

@Mariatta, Are you thinking of https://bugs.python.org/issue29555 ? That also covers copyright dates in a number of modules.

@Mariatta
Copy link
Member

Mariatta commented Nov 9, 2018

Ah yeah that's the issue I was thinking.

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miss-islington miss-islington merged commit 9d43fa1 into python:master Nov 10, 2018
@Mariatta
Copy link
Member

Thanks @davidak and congrats on your first contribution to CPython 🌮

@davidak davidak deleted the patch-1 branch November 10, 2018 16:25
Stevoisiak added a commit to Stevoisiak/cpython that referenced this pull request Feb 8, 2023
Uses a range of years for the copyright in LICENSE file. Follows up on python#10287 and makes it consistent with other copyright notices).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants