-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-35128: Fix spacing issues in warning.warn messages #10268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double space after a period is not a bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double spaces after the "." are intentional and should be kept, the others are bugs and should be fixed.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Agreed on the double spaces as they increase readability (of the messages) 👍 Should I include a news entry or are you going to add that label? Thanks a lot for reviewing!! |
Great! Can I help backporting!? |
Thanks @scorphus for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
Sorry, @scorphus and @serhiy-storchaka, I could not cleanly backport this to |
Sorry, @scorphus and @serhiy-storchaka, I could not cleanly backport this to |
…onGH-10268). (cherry picked from commit 4b5e62d) Co-authored-by: Pablo Aguiar <scorphus@gmail.com>
GH-10280 is a backport of this pull request to the 3.7 branch. |
…onGH-10268). (cherry picked from commit 4b5e62d) Co-authored-by: Pablo Aguiar <scorphus@gmail.com>
GH-10281 is a backport of this pull request to the 3.6 branch. |
Some warn messages miss space between words, such as:
in
bz2
library, and:in many libraries, such as
poplib
andsmtplib
.Other warn messages contain too much spaces between words, such as:
in
configparser
library.As "Trivial changes, like fixing a typo, do not need an issue", I closed the one I had previously opened (issue35128)
https://bugs.python.org/issue35128