Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35128: Fix spacing issues in warning.warn messages #10268

Merged
merged 2 commits into from
Nov 1, 2018

Conversation

scorphus
Copy link
Contributor

@scorphus scorphus commented Oct 31, 2018

Some warn messages miss space between words, such as:

Use of 'buffering' argument is deprecated  and ignoredsince Python 3.0.

in bz2 library, and:

keyfile and certfile are deprecated, use acustom context instead

in many libraries, such as poplib and smtplib.

Other warn messages contain too much spaces between words, such as:

The 'filename' attribute will be removed in future versions.  Use 'source' instead.

in configparser library.

As "Trivial changes, like fixing a typo, do not need an issue", I closed the one I had previously opened (issue35128)

https://bugs.python.org/issue35128

@daniellovell
Copy link
Contributor

daniellovell commented Oct 31, 2018

Hi @scorphus, to address some of the errored and failing checks you're receiving, I'd recommend putting the Python BPO issue number in the title of your PR as detailed in the devguide.

e.g. "bpo-35128: Fix spacing issues in warning.warn messages"

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double space after a period is not a bug.

@serhiy-storchaka serhiy-storchaka changed the title Fix spacing issues in warning.warn messages bpo-35128: Fix spacing issues in warning.warn messages Nov 1, 2018
Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double spaces after the "." are intentional and should be kept, the others are bugs and should be fixed.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@scorphus
Copy link
Contributor Author

scorphus commented Nov 1, 2018

Agreed on the double spaces as they increase readability (of the messages) 👍

Should I include a news entry or are you going to add that label?

Thanks a lot for reviewing!!

@scorphus
Copy link
Contributor Author

scorphus commented Nov 1, 2018

Great! Can I help backporting!?

@serhiy-storchaka serhiy-storchaka merged commit 4b5e62d into python:master Nov 1, 2018
@miss-islington
Copy link
Contributor

Thanks @scorphus for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @scorphus and @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4b5e62dbb22a3593e0db266c12f805b727a42b00 3.7

@miss-islington
Copy link
Contributor

Sorry, @scorphus and @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4b5e62dbb22a3593e0db266c12f805b727a42b00 3.6

@scorphus scorphus deleted the bpo-35128 branch November 1, 2018 11:21
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Nov 1, 2018
…onGH-10268).

(cherry picked from commit 4b5e62d)

Co-authored-by: Pablo Aguiar <scorphus@gmail.com>
@bedevere-bot
Copy link

GH-10280 is a backport of this pull request to the 3.7 branch.

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Nov 1, 2018
…onGH-10268).

(cherry picked from commit 4b5e62d)

Co-authored-by: Pablo Aguiar <scorphus@gmail.com>
@bedevere-bot
Copy link

GH-10281 is a backport of this pull request to the 3.6 branch.

@serhiy-storchaka serhiy-storchaka removed their assignment Nov 1, 2018
serhiy-storchaka added a commit that referenced this pull request Nov 1, 2018
…0268). (GH-10280)

(cherry picked from commit 4b5e62d)

Co-authored-by: Pablo Aguiar <scorphus@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Nov 1, 2018
…0268). (GH-10281)

(cherry picked from commit 4b5e62d)

Co-authored-by: Pablo Aguiar <scorphus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants