[3.7] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286)#101713
Merged
ambv merged 2 commits intopython:3.7from Feb 9, 2023
Merged
[3.7] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286)#101713ambv merged 2 commits intopython:3.7from
ambv merged 2 commits intopython:3.7from
Conversation
zooba
changed the title
Member
Author
|
macOS crash is due to underlying OS update and not related to this PR. |
Member
|
Undrafting since the introduced bug will be fixed separately by backports of gh-101712. My apologizes for the confusion; I didn't sort out my incoming notifications timely. |
arhadthedev
reviewed
Feb 9, 2023
Comment on lines
+453
to
+454
| .. versionchanged:: 3.6 | ||
| *executable* parameter accepts a :term:`path-like object` on POSIX. |
Contributor
There was a problem hiding this comment.
It was probably added to resolve the conflict but it belongs in the 3.7 docs as well. For some reason this doc bit wasn't ported back to 3.6 and 3.7 when Serhiy landed GH-5914.
I would leave it in.
arhadthedev
reviewed
Feb 9, 2023
Member
arhadthedev
left a comment
arhadthedev
left a comment
There was a problem hiding this comment.
According to https://www.python.org/downloads/ the next published 3.7 release will be 3.7.17.
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.