Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) #101713

Merged
merged 2 commits into from
Feb 9, 2023
Merged

[3.7] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) #101713

merged 2 commits into from
Feb 9, 2023

Conversation

zooba
Copy link
Member

@zooba zooba commented Feb 8, 2023 •
edited by bedevere-bot
Loading

@zooba zooba requested a review from gpshead as a code owner February 8, 2023 22:36
@bedevere-bot bedevere-bot mentioned this pull request Feb 8, 2023
Closed
@zooba zooba changed the title gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) [3.7] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) Feb 8, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 8, 2023
Merged
@bedevere-bot bedevere-bot added the type-security A security issue label Feb 8, 2023
@zooba
Copy link
Member Author

zooba commented Feb 8, 2023

macOS crash is due to underlying OS update and not related to this PR.

@arhadthedev arhadthedev marked this pull request as draft February 9, 2023 03:38
@arhadthedev
Copy link
Member

Undrafting since the introduced bug will be fixed separately by backports of gh-101712. My apologizes for the confusion; I didn't sort out my incoming notifications timely.

@arhadthedev arhadthedev marked this pull request as ready for review February 9, 2023 06:15
arhadthedev
arhadthedev reviewed Feb 9, 2023
View reviewed changes
Doc/library/subprocess.rst
Comment on lines +453 to +454
.. versionchanged:: 3.6
*executable* parameter accepts a :term:`path-like object` on POSIX.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it added by mistake?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was probably added to resolve the conflict but it belongs in the 3.7 docs as well. For some reason this doc bit wasn't ported back to 3.6 and 3.7 when Serhiy landed GH-5914.

I would leave it in.

arhadthedev
arhadthedev reviewed Feb 9, 2023
View reviewed changes
Copy link
Member

@arhadthedev arhadthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://www.python.org/downloads/ the next published 3.7 release will be 3.7.17.

Doc/library/subprocess.rst Outdated Show resolved Hide resolved
Doc/library/subprocess.rst Outdated Show resolved Hide resolved
Doc/library/subprocess.rst Outdated Show resolved Hide resolved
Doc/library/subprocess.rst Outdated Show resolved Hide resolved
Doc/library/subprocess.rst Outdated Show resolved Hide resolved
@ambv @arhadthedev
Apply suggestions from code review
3196632 
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
@ambv ambv merged commit c7fdc9c into python:3.7 Feb 9, 2023
@zooba zooba deleted the gh-101283-3.7 branch February 9, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambv ambv ambv left review comments

@arhadthedev arhadthedev arhadthedev left review comments

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees
No one assigned
Labels
type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zooba @arhadthedev @ambv @bedevere-bot