Skip to content

gh-89381: Fix invalid signatures of math/cmath.log#101404

Merged
hauntsaninja merged 3 commits into
python:mainfrom
skirpichev:fix-89381
Jan 29, 2023
Merged

gh-89381: Fix invalid signatures of math/cmath.log#101404
hauntsaninja merged 3 commits into
python:mainfrom
skirpichev:fix-89381

Conversation

@skirpichev

@skirpichev skirpichev commented Jan 29, 2023

Copy link
Copy Markdown
Member

@skirpichev

skirpichev commented Jan 29, 2023

Copy link
Copy Markdown
Member Author

Probably, changes in the math.rst could be reverted too (like 1efcf49 does) reworded like "If the base is not specified returns the natural logarithm (base e) of x.".

BTW, I would appreciate Raymond's review too.

@mdickinson

Copy link
Copy Markdown
Member

Yes, I'd suggest losing the or is None in the math.rst, too. Other than that, this LGTM.

Comment thread Doc/library/math.rst Outdated

@mdickinson mdickinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skirpichev

Copy link
Copy Markdown
Member Author

Thanks for review and I'm sorry for the closed pr.

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sticking with this!

@hauntsaninja hauntsaninja merged commit 0ef92d9 into python:main Jan 29, 2023
@skirpichev skirpichev deleted the fix-89381 branch January 29, 2023 23:55
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
mdickinson added a commit to mdickinson/cpython that referenced this pull request Feb 5, 2023
skirpichev added a commit to skirpichev/cpython that referenced this pull request Feb 6, 2023
@skirpichev

Copy link
Copy Markdown
Member Author

Restored in #101593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants