Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-99276 - Updated Doc/faq/general.rst #101396

Merged
merged 10 commits into from
Jan 31, 2023
Merged

gh-99276 - Updated Doc/faq/general.rst #101396

merged 10 commits into from
Jan 31, 2023

Conversation

workingpayload
Copy link
Contributor

@workingpayload workingpayload commented Jan 28, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jan 28, 2023
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Jan 28, 2023
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jan 28, 2023 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

hugovk
hugovk requested changes Jan 29, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but:

Issue gh-99276 was about adding the https://ir.cwi.nl/pub/18204 article link to that articles section:

Please could you update the PR?

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@workingpayload
Copy link
Contributor Author

Thanks for the PR, but:

Issue gh-99276 was about adding the https://ir.cwi.nl/pub/18204 article link to that articles section:

Please could you update the PR?

Yeah Sure!!

@workingpayload
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

@hugovk
Copy link
Member

hugovk commented Jan 29, 2023

Rather than adding that extra line, shall we add an inline link?

For example, to add the link around "very first article":

-The very first article about Python was written in 1991 and is now quite
-outdated.
+The `very first article <https://ir.cwi.nl/pub/18204>` about Python was 
+written in 1991 and is now quite outdated.

@workingpayload
Copy link
Contributor Author

Rather than adding that extra line, shall we add an inline link?

For example, to add the link around "very first article":

-The very first article about Python was written in 1991 and is now quite
-outdated.
+The `very first article <https://ir.cwi.nl/pub/18204>` about Python was 
+written in 1991 and is now quite outdated.

Yeah sure!!
I'll do that.
Thank you for helping me out.

@workingpayload
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

hugovk
hugovk reviewed Jan 30, 2023
View reviewed changes
Doc/faq/general.rst Outdated Show resolved Hide resolved
Doc/faq/general.rst Outdated Show resolved Hide resolved
@workingpayload
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

workingpayload and others added 2 commits January 30, 2023 15:29
@workingpayload @hugovk
Update Doc/faq/general.rst
f50ec70 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@workingpayload
Merge branch 'main' into workingpayload/issue99276
4976d3a
hugovk
hugovk reviewed Jan 30, 2023
View reviewed changes
Doc/faq/general.rst Outdated Show resolved Hide resolved
@workingpayload @hugovk
Update Doc/faq/general.rst
a211ee5 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk
hugovk approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 30, 2023
@hugovk hugovk merged commit df0068c into python:main Jan 31, 2023
@miss-islington
Copy link
Contributor

Thanks @workingpayload for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-101461 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 31, 2023
@bedevere-bot
Copy link

GH-101462 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 31, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2023
@workingpayload @hugovk @miss-islington
pythongh-99276 - Updated Doc/faq/general.rst (pythonGH-101396)
de447d9 
(cherry picked from commit df0068c)

Co-authored-by: Raj <51259329+workingpayload@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2023
@workingpayload @hugovk @miss-islington
pythongh-99276 - Updated Doc/faq/general.rst (pythonGH-101396)
3232abc 
(cherry picked from commit df0068c)

Co-authored-by: Raj <51259329+workingpayload@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jan 31, 2023
@miss-islington @workingpayload @hugovk
gh-99276 - Updated Doc/faq/general.rst (GH-101396)
9e4ba5c 
(cherry picked from commit df0068c)

Co-authored-by: Raj <51259329+workingpayload@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Jan 31, 2023
@miss-islington @workingpayload @hugovk
[3.10] gh-99276 - Updated Doc/faq/general.rst (GH-101396) (#101462)
ca11848 
Co-authored-by: Raj <51259329+workingpayload@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
@workingpayload @hugovk @mdboom
pythongh-99276 - Updated Doc/faq/general.rst (python#101396)
9fd32e8 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
carljm added a commit to carljm/cpython that referenced this pull request Jan 31, 2023
@carljm
Merge branch 'main' into inlinecomp2
ed3209b 
* main:
  pythongh-101440: fix json snippet error in logging-cookbook.rst (python#101439)
  pythongh-99276 - Updated Doc/faq/general.rst (python#101396)
  Add JOBS parameter to docs Makefile (python#101395)
  pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL (python#101443)
  pythongh-77607: Improve accuracy of os.path.join docs (python#101406)
  Fixes typo in asyncio.TaskGroup context manager code example (python#101449)
  pythongh-98831: Clean up and add cache size static_assert to macro (python#101442)
  pythongh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)
@workingpayload workingpayload deleted the workingpayload/issue99276 branch February 1, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@workingpayload @bedevere-bot @hugovk @miss-islington