gh-100574: add examples/links to the strptime/strftime docs
#100575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezio-melotti
added
type-feature
ezio-melotti
commented
Dec 28, 2022
| @@ -737,18 +737,16 @@ Instance methods: | |||
| .. method:: date.strftime(format) | |||
|
|
|||
| Return a string representing the date, controlled by an explicit format string. | |||
| Format codes referring to hours, minutes or seconds will see 0 values. For a | |||
| complete list of formatting directives, see | |||
| :ref:`strftime-strptime-behavior`. | |||
There was a problem hiding this comment.
This ref is converted to the title of the section: strftime() and strptime() Behavior. The actual list of format codes is actually a subsection. Adding a label to the subsection and updating the ref might result in a more readable sentence.
ezio-melotti
commented
Dec 28, 2022
Comment on lines
+2323
to
+2327
| >>> datetime.strptime('31/01/22 23:59:59.999999', | ||
| ... '%d/%m/%y %H:%M:%S.%f') | ||
| datetime.datetime(2022, 1, 31, 23, 59, 59, 999999) | ||
| >>> _.strftime('%a %d %b %Y, %I:%M%p') | ||
| 'Mon 31 Jan 2022, 11:59PM' |
There was a problem hiding this comment.
In this example I tried to capture as many format codes as possible in a way that makes it easy to find which part corresponds to which code.
|
Thanks @ezio-melotti for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-103368 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 8, 2023
…pythonGH-100575) (cherry picked from commit 3310b94) Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Apr 8, 2023
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strptime/strftimeformat code examples #100574