[3.11] gh-100474: Fix handling of dirs named index.html in http.server (GH-100475) #100505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pythonGH-100475) If you had a directory called index.html or index.htm within a directory, it would cause http.server to return a 404 Not Found error instead of the directory listing. This came about due to not checking that the index was a regular file. I have also added a test case for this situation. (cherry picked from commit 46e6a28) Co-authored-by: James Frost <git@frost.cx> Automerge-Triggered-By: GH:merwok
This was referenced Dec 24, 2022
bedevere-bot
added
type-bug
merwok
approved these changes
Dec 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you had a directory called index.html or index.htm within a directory, it would cause http.server
to return a 404 Not Found error instead of the directory listing. This came about due to not checking
that the index was a regular file.
(cherry picked from commit 46e6a28)
Co-authored-by: James Frost git@frost.cx