-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-99908 Update class documentation to use a modernized example #100433
Conversation
The following commit authors need to sign the Contributor License Agreement: |
278affa
to
b02d708
Compare
Hi, @JosephSBoyle! Could you please sign a CLA? We cannot accept your PR without it :( |
Hi @sobolevn. I have accepted the CLA. Can you re-run the check please? (I had to change my email address in the commit to my GH one). |
b02d708
to
299ecee
Compare
1ebe525
to
d6e1eb9
Compare
@JosephSBoyle are you sure that your |
d6e1eb9
to
a3a1750
Compare
a3a1750
to
3021b7c
Compare
Hi @sobolevn, thanks for the reminder- I had to rebase and edit my email in the commit log to have the same email as my CLA. Should be fine now:) |
Looks like the CLA bot is still being grumpy — it might be easier to just close the PR and recreate it :) |
Small update to the docs to improve on an outmoded example from 15 years ago.
The aim of this change is to give readers of the docs a more idiomatic example.