error handling in the compiler is inconsistent

[iritkatriel]

In compile.c some function return 0 for failure and 1 for success, and some return -1 for failure and 0 for success.

Should be -1 / 0 consistently.

Linked PRs

• gh-99955: standardize return values of functions in assembler and optimizer. #99956
• gh-99955: standardize return values of functions in compiler's code-gen #100010
• gh-99955: undef ERROR and SUCCESS before redefining (fixes sanitizer warning) #100215
• gh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. #101412

[ramvikrams]

can I still work on this or is it done

[iritkatriel]

I’m working on it, it’s mostly done. Assigning to myself to finish.

[ramvikrams]

ok