Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unneeded include in call.c #93785

Closed
pamelafox opened this issue Jun 13, 2022 · 1 comment
Closed

Unneeded include in call.c #93785

pamelafox opened this issue Jun 13, 2022 · 1 comment

Comments

@pamelafox
Copy link
Contributor

Bug report

Objects/call.c has:

#include "frameobject.h" // _PyFrame_New_NoTrack()

However, it no longer uses _PyFrame_New_NoTrack - that was removed in PR #24368
https://github.com/python/cpython/pull/24368/files#diff-b876797aa8c96d633b0b869447e7e14da64b9f53e48561149446939e7c6257e9

It also does not use any other functions from frameobject.h, and CPython compiles fine without it.

I will send a PR shortly with its removal.

Your environment

  • CPython versions tested on: main branch
  • Operating system and architecture: Mac OS X
@pamelafox pamelafox added the type-bug An unexpected behavior, bug, or error label Jun 13, 2022
@pamelafox pamelafox mentioned this issue Jun 13, 2022
Merged
@iritkatriel iritkatriel removed the type-bug An unexpected behavior, bug, or error label Jun 14, 2022
@kumaraditya303
Copy link
Contributor

Fixed by #93786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pamelafox @iritkatriel @kumaraditya303