SymbolTable.get_identifiers() docstring return value incorrect

[pamelafox]

Documentation

SymbolTable.get_identifiers() currently says:
"Return a list of names of symbols in this table."

However, the returned value is actually dict_keys, a dictionary view object, which doesn't support everything that a list does (notably, it's not subscriptable).

I have a PR with a proposed change incoming.

[pamelafox]

Alternatively, that method could return a list by wrapping the return value in list(), but that could potentially be backward incompatible so I assume its preferable to just update the documentation.

[hauntsaninja]

Thanks for spotting this! As an aside, looks like the type in typeshed is also incorrect, in case you feel like making another PR: https://github.com/python/typeshed/blob/ad48606a0d901d907f2428917d7a5f97959b4733/stdlib/symtable.pyi#L21 :-)

[pamelafox]

Sure, typeshed PR is here:
python/typeshed#8054
CPython PR is here:
#93661

[AlexWaygood]

Fixed in:

• gh-93660: Change list to view object in SymbolTable docstring #93661
• [3.11] Change list to view object (GH-93661) #93722
• [3.10] Change list to view object (GH-93661) #93723

Thanks, @pamelafox!