Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools/c-analyzer is out-of-date. #90110

Closed
ericsnowcurrently opened this issue Dec 1, 2021 · 4 comments
Closed

Tools/c-analyzer is out-of-date. #90110

ericsnowcurrently opened this issue Dec 1, 2021 · 4 comments
Assignees
Labels
3.11 only security fixes type-bug An unexpected behavior, bug, or error

Comments

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Dec 1, 2021

BPO 45952
Nosy @ericsnowcurrently
PRs
  • bpo-45952: Get the C analyzer tool working again. #29882
  • bpo-45952: Get the C analyzer tool working again. #31219
  • bpo-45952: Get the C analyzer tool working again. #31220
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ericsnowcurrently'
    closed_at = <Date 2021-12-01.18:20:52.798>
    created_at = <Date 2021-12-01.17:49:22.763>
    labels = ['type-bug', '3.11']
    title = 'Tools/c-analyzer is out-of-date.'
    updated_at = <Date 2022-02-08.19:38:00.941>
    user = 'https://github.com/ericsnowcurrently'

    bugs.python.org fields:

    activity = <Date 2022-02-08.19:38:00.941>
    actor = 'eric.snow'
    assignee = 'eric.snow'
    closed = True
    closed_date = <Date 2021-12-01.18:20:52.798>
    closer = 'eric.snow'
    components = ['Demos and Tools']
    creation = <Date 2021-12-01.17:49:22.763>
    creator = 'eric.snow'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 45952
    keywords = []
    message_count = 4.0
    messages = ['407474', '407475', '412859', '412862']
    nosy_count = 1.0
    nosy_names = ['eric.snow']
    pr_nums = ['29882', '31219', '31220']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue45952'
    versions = ['Python 3.11']

    @ericsnowcurrently
    Copy link
    Member Author

    Some relatively recent changes broke "./python Tools/c-analyzer/c-analyzer.py ...". Also, Tools/c-analyzer/TODO is a bit out of date.

    @ericsnowcurrently ericsnowcurrently added the 3.11 only security fixes label Dec 1, 2021
    @ericsnowcurrently ericsnowcurrently self-assigned this Dec 1, 2021
    @ericsnowcurrently ericsnowcurrently added type-bug An unexpected behavior, bug, or error 3.11 only security fixes labels Dec 1, 2021
    @ericsnowcurrently ericsnowcurrently self-assigned this Dec 1, 2021
    @ericsnowcurrently ericsnowcurrently added the type-bug An unexpected behavior, bug, or error label Dec 1, 2021
    @ericsnowcurrently
    Copy link
    Member Author

    New changeset ee94aa0 by Eric Snow in branch 'main':
    bpo-45952: Get the C analyzer tool working again. (gh-29882)
    ee94aa0

    @ericsnowcurrently
    Copy link
    Member Author

    New changeset 1e6214d by Eric Snow in branch 'main':
    bpo-45952: Get the C analyzer tool working again. (gh-31219)
    1e6214d

    @ericsnowcurrently
    Copy link
    Member Author

    New changeset c018d30 by Eric Snow in branch 'main':
    bpo-45952: Get the C analyzer tool working again. (gh-31220)
    c018d30

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    ericsnowcurrently added a commit that referenced this issue Aug 17, 2022
    We broke it with a recent `_PyArg_Parser` change.
    
    Also:
    * moved the `_PyArg_Parser` whitelist entries over to ignored.tsv now that they are thread-safe
    * added some known globals from a currently-excluded file
    * dropped some outdated globals from the whitelist
    tiran pushed a commit to tiran/cpython that referenced this issue Aug 19, 2022
    We broke it with a recent `_PyArg_Parser` change.
    
    Also:
    * moved the `_PyArg_Parser` whitelist entries over to ignored.tsv now that they are thread-safe
    * added some known globals from a currently-excluded file
    * dropped some outdated globals from the whitelist
    tiran pushed a commit to tiran/cpython that referenced this issue Aug 19, 2022
    ericsnowcurrently added a commit that referenced this issue Aug 25, 2022
    Here we automatically ignore uses of _PyArg_Parser, "kwlist" arrays, and module/type defs. That way new uses don't trigger false positives in the c-analyzer check script.
    ericsnowcurrently added a commit that referenced this issue Sep 12, 2022
    This includes:
    
    * update the whitelists
    * fixes so we can stop ignoring some of the files
    * ensure Include/cpython/*.h get analyzed
    serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this issue Oct 2, 2022
    gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue Nov 10, 2022
    ethanfurman pushed a commit to ethanfurman/cpython that referenced this issue Nov 12, 2022
    ericsnowcurrently added a commit that referenced this issue Mar 7, 2023
    Some incompatible changes had gone in, and the "ignore" lists weren't properly undated. This change fixes that. It's necessary prior to enabling test_check_c_globals, which I hope to do soon.
    
    Note that this does include moving last_resort_memory_error to PyInterpreterState.
    
    #90110
    carljm added a commit to carljm/cpython that referenced this issue Mar 7, 2023
    * main:
      pythongh-102493: fix normalization in PyErr_SetObject (python#102502)
      pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320)
      pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781)
      Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398)
      pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429)
      pythongh-90110: Fix the c-analyzer Tool (python#102483)
      pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485)
      Remove unused import of `warnings` from `unittest.loader` (python#102479)
      Add gettext support to tools/extensions/c_annotations.py (python#101989)
    carljm added a commit to carljm/cpython that referenced this issue Mar 8, 2023
    * main:
      pythongh-102493: fix normalization in PyErr_SetObject (python#102502)
      pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320)
      pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781)
      Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398)
      pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429)
      pythongh-90110: Fix the c-analyzer Tool (python#102483)
      pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485)
      Remove unused import of `warnings` from `unittest.loader` (python#102479)
      Add gettext support to tools/extensions/c_annotations.py (python#101989)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 only security fixes type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants
    @ericsnowcurrently and others