Skip to content

Do not build the freeze module twice in case of Windows PGO builds #130419

Closed
@chris-eibl

Description

@chris-eibl

Feature or enhancement

Proposal:

From #129907 (comment)

Avoiding the rebuild of _freeze_module and the refreezing would be nice, but it's not a huge deal (a few seconds in a ~hour long release process). Don't mix it in with this PR.

This is another low hanging fruit to make the Windows PGO build slightly faster (like #90281 did) by not building the _freeze_module again in the PGUpdate phase.

This will decrease both the MSVC and the clang-cl PGO build time (#130090).

In case of clang-cl, this saves me up to 40 seconds on my machine. Please see #131005 Details pgupdate build times for more numbers

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs

Metadata

Metadata

Assignees

No one assigned

    Labels

    OS-windowsbuildThe build process and cross-buildtype-featureA feature request or enhancement

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions