Skip to content

"Check if generated files are up to date" job misses regen-unicodedata and regen-limited-abi #126524

Open
@sobolevn

Description

@sobolevn

Feature or enhancement

Currently our regen-all is missing several regen- targets:

@echo "Note: make regen-stdlib-module-names, make regen-limited-abi, "
@echo "make regen-configure, make regen-sbom, and make regen-unicodedata should be run manually"

While our CI job to check regenerated files does not check them:

- name: Build CPython
run: |
make -j4 regen-all
make regen-stdlib-module-names regen-sbom
- name: Check for changes

This does not seem right, I think that we should add:

How long does it work? Testing locally first:

make regen-unicodedata  9.44s user 0.47s system 27% cpu 35.719 total
make regen-limited-abi  2.35s user 0.76s system 77% cpu 4.019 total (with pre-existing cache)

I propose adding these two make targets to the test to be extra safe.
What do others think? :)
If agreed, I will send a PR.

Linked PRs

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildThe build process and cross-buildtype-featureA feature request or enhancement

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions