Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip additional tests for emulated Linux JIT CI jobs #124408

Closed
savannahostrowski opened this issue Sep 24, 2024 · 2 comments
Closed

Skip additional tests for emulated Linux JIT CI jobs #124408

savannahostrowski opened this issue Sep 24, 2024 · 2 comments
Assignees
Labels
build The build process and cross-build topic-JIT

Comments

@savannahostrowski
Copy link
Member

savannahostrowski commented Sep 24, 2024

There have been a number of failed tests on emulated Linux JIT CI runs, related totest_datetime lately. We should add them to the list of skipped tests for now.

See https://github.com/python/cpython/actions/runs/10942493409/job/30380093772?pr=124101 as an example.

Linked PRs

@savannahostrowski savannahostrowski added build The build process and cross-build topic-JIT labels Sep 24, 2024
@savannahostrowski savannahostrowski self-assigned this Sep 24, 2024
@savannahostrowski savannahostrowski changed the title Skip more tests for Emulated Linux JIT CI Jobs Skip tests for Emulated Linux JIT CI jobs Sep 24, 2024
@savannahostrowski savannahostrowski changed the title Skip tests for Emulated Linux JIT CI jobs Skip additional tests for emulated Linux JIT CI jobs Sep 24, 2024
@blhsing
Copy link
Contributor

blhsing commented Sep 24, 2024

@savannahostrowski It seems that @serhiy-storchaka has been relatively busy since I submitted PR #123861 to fix the test_datetime issue for Linux JIT CI runs two weeks ago. Instead of skipping the test do you think you can help take a look into reviewing the PR?

@savannahostrowski
Copy link
Member Author

@blhsing Thanks for sharing this - it slipped past my inbox. I don't have the expertise to know if that change will resolve the problem, so I'll leave the review to others for now. That said, it'd be ideal to land a more robust fix for this. The skipped tests may address the problem in the short term. I'm happy to revert the change later on if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build topic-JIT
Projects
None yet
Development

No branches or pull requests

2 participants