Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider marking zip64 tests in test_zipimport as cpu-heavy #120560

Closed
Eclips4 opened this issue Jun 15, 2024 · 1 comment
Closed

Consider marking zip64 tests in test_zipimport as cpu-heavy #120560

Eclips4 opened this issue Jun 15, 2024 · 1 comment
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@Eclips4
Copy link
Member

Eclips4 commented Jun 15, 2024

Feature or enhancement

Proposal:

Without testZip64 and testZip64CruftAndComment test_zipimport takes about ~300ms:

./python -m test -q test_zipimport
Using random seed: 4154114933
0:00:00 load avg: 0.02 Run 1 test sequentially in a single process

== Tests result: SUCCESS ==

Total duration: 270 ms
Total tests: run=81 skipped=6
Total test files: run=1/1
Result: SUCCESS

With them, about ~35 seconds:

./python -m test -q test_zipimport
Using random seed: 3529335933
0:00:00 load avg: 0.01 Run 1 test sequentially in a single process
test_zipimport passed in 35.0 sec

== Tests result: SUCCESS ==

Total duration: 35.0 sec
Total tests: run=81 skipped=2
Total test files: run=1/1
Result: SUCCESS

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs

@Eclips4 Eclips4 added type-feature A feature request or enhancement tests Tests in the Lib/test dir labels Jun 15, 2024
@nineteendo
Copy link
Contributor

It's one of the 10 slowest tests:

10 slowest tests:
- test_free_threading: 2 min 42 sec
- test.test_multiprocessing_forkserver.test_processes: 1 min 4 sec
- test.test_multiprocessing_spawn.test_processes: 58.9 sec
- test.test_concurrent_futures.test_wait: 52.2 sec
- test_socket: 46.9 sec
- test.test_multiprocessing_spawn.test_misc: 42.5 sec
- test_regrtest: 41.9 sec
- test_zipimport: 40.5 sec
- test_io: 38.9 sec
- test.test_gdb.test_pretty_print: 38.0 sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants