Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus M1 macOS runners never start on fork #120111

Closed
nineteendo opened this issue Jun 5, 2024 · 3 comments
Closed

Cirrus M1 macOS runners never start on fork #120111

nineteendo opened this issue Jun 5, 2024 · 3 comments

Comments

@nineteendo
Copy link
Contributor

nineteendo commented Jun 5, 2024

The Cirrus M1 macOS runners introduced in #119979 never start on my fork. This causes every workflow to fail. Can we skip this job in that case?

Linked PRs

@hugovk
Copy link
Member

hugovk commented Jun 5, 2024

Yes, does something like this in .github/workflows/reusable-macos.yml work?

  build_macos:
    name: 'build and test'
    if: |
      github.repository_owner != 'python'
      && matrix.os == 'ghcr.io/cirruslabs/macos-runner:sonoma'

@nineteendo nineteendo changed the title Cirrus M1 macOS runners never start on pull request on fork Cirrus M1 macOS runners never start on fork Jun 5, 2024
nineteendo added a commit to nineteendo/cpython that referenced this issue Jun 5, 2024
@nineteendo
Copy link
Contributor Author

Didn't work.

@nineteendo
Copy link
Contributor Author

nineteendo commented Jun 5, 2024

Currently trying this:

      matrix:
        os: ${{fromJson(inputs.os-matrix)}}
        isFork: ${{ github.repository_owner != 'python' }}
        exclude:
          - isFork: true
            os: 'ghcr.io/cirruslabs/macos-runner:sonoma'

isFork needs to be an array.

ambv pushed a commit that referenced this issue Jun 6, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 6, 2024
…120116)

(cherry picked from commit fd104df)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
ambv pushed a commit to ambv/cpython that referenced this issue Jun 6, 2024
…thonGH-120116)

(cherry picked from commit fd104df)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
ambv pushed a commit that referenced this issue Jun 6, 2024
… (GH-120152)

(cherry picked from commit fd104df)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
ambv added a commit that referenced this issue Jun 6, 2024
… (GH-120153)

(cherry picked from commit fd104df)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@ambv ambv closed this as completed Jun 6, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
…0116)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
…0116)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants