Skip to content

Make random.Random thread-safe in --disable-gil builds #112071

Closed
@colesbury

Description

@colesbury

Feature or enhancement

random.Random has mutable internal state. We should use the critical section API to make it thread-safe in --disable-gil builds.

For context, here is the change from the nogil-3.12 fork. colesbury/nogil-3.12@9bf62ffc4b. Note that we want to do things a bit differently in CPython 3.13:

  1. No need for an extra _PyMutex mutex in RandomObject
  2. Use the critical section API. Locking can be added around operations that use Argument Clinic by adding the @critical_section directive as the first line.
  3. Compared to nogil-3.12, we want to push the locking "up" to the around the methods. (See the above note 2).

Linked PRs

Activity

chgnrdv

chgnrdv commented on Nov 15, 2023

@chgnrdv
Contributor

The PR is done.

added a commit that references this issue on Nov 28, 2023

gh-112071: Make `_random.Random` methods thread-safe in `--disable-gi…

ac4b442
added a commit that references this issue on Feb 11, 2024

pythongh-112071: Make `_random.Random` methods thread-safe in `--disa…

added a commit that references this issue on Sep 2, 2024

pythongh-112071: Make `_random.Random` methods thread-safe in `--disa…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Make `random.Random` thread-safe in `--disable-gil` builds · Issue #112071 · python/cpython