Skip to content

test_monitoring has duplicated tests #106193

Closed
@sobolevn

Description

@sobolevn

Based on python/core-workflow#505 by @hugovk

Lib/test/test_monitoring.py:973:5: F811 redefinition of unused 'test_line_then_instruction' from line 950
Lib/test/test_monitoring.py:978:5: F811 redefinition of unused 'test_instruction_then_line' from line 955

Before rename: Ran 49 tests in 0.014s
After rename:

======================================================================
ERROR: test_instruction_then_line (test.test_monitoring.TestInstallIncrementallly.test_instruction_then_line)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/sobolev/Desktop/cpython/Lib/test/test_monitoring.py", line 956, in test_instruction_then_line
    recorders = [ InstructionRecorder, LineRecorderLowNoise ]
                                       ^^^^^^^^^^^^^^^^^^^^
NameError: name 'LineRecorderLowNoise' is not defined

======================================================================
ERROR: test_line_then_instruction (test.test_monitoring.TestInstallIncrementallly.test_line_then_instruction)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/sobolev/Desktop/cpython/Lib/test/test_monitoring.py", line 953, in test_line_then_instruction
    recorders = recorders, must_include = self.EXPECTED_LI)
                                          ^^^^^^^^^^^^^^^^
AttributeError: 'TestInstallIncrementallly' object has no attribute 'EXPECTED_LI'

----------------------------------------------------------------------
Ran 51 tests in 0.045s

FAILED (errors=2)
test test_monitoring failed
test_monitoring failed (2 errors)

== Tests result: FAILURE ==

1 test failed:
    test_monitoring

Total duration: 94 ms
Tests result: FAILURE

Based on the missing runtime parts in these tests, we can just remove the first two ones, I guess.

Both of these tests were introduced in 411b169 by @markshannon

Linked PRs

Metadata

Metadata

Assignees

Labels

3.12only security fixes3.13bugs and security fixestestsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions