Skip to content

Too many misses in BINARY_SUBSCR_LIST_INT #100188

Closed
Closed
Too many misses in BINARY_SUBSCR_LIST_INT#100188
Labels
type-featureA feature request or enhancement

Description

@sweeneyde
sweeneyde
opened on Dec 12, 2022

The expression my_list[-1] gets specialized to BINARY_SUBSCR_LIST_INT every time, then it gets deoptimized every time

This leads to 31%ish of BINARY_SUBSCR_LIST_INT executions being misses (on some programs anyway). Edit: this stat was probably not accurate.

Should be an easy fix.

Linked PRs

Activity

  1. sweeneyde
    added
    type-featureA feature request or enhancement
    on Dec 12, 2022
  2. sweeneyde
    added a commit that references this issue on Dec 20, 2022

    gh-100188: Reduce misses in BINARY_SUBSCR_(LIST/TUPLE)_INT (#100189)

    c18d831
  3. kumaraditya303
    closed this as completedon Dec 21, 2022

  4. hauntsaninja commented on Dec 21, 2022

    @hauntsaninja
    hauntsaninja
    on Dec 21, 2022
    Contributor

    Thanks for finding and fixing!

  5. hauntsaninja
    closed this as completedon Dec 21, 2022
  6. iritkatriel
    added a commit that references this issue on Dec 28, 2022

    Merged main into regmachine branch (#50)

    fdc73cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions