Skip to content

Commit fe9b91d

Browse files
committed
Update test_union operators in test_collections.py
Gave more descriptive variable names and eliminated unnecessary tmp variable.
1 parent dd2ab1a commit fe9b91d

File tree

1 file changed

+17
-18
lines changed

1 file changed

+17
-18
lines changed

Lib/test/test_collections.py

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -233,28 +233,27 @@ def __contains__(self, key):
233233
self.assertEqual(d.get(k, 100), v)
234234

235235
def test_union_operators(self):
236-
a = ChainMap(dict(a=1, b=2), dict(c=3, d=4))
237-
b = ChainMap(dict(a=10, e=5), dict(b=20, d=4))
238-
c = dict(a=10, c=30)
239-
d = [('a', 1), ('c',3)]
240-
241-
e = a | b # testing between chainmaps
242-
self.assertEqual(e, ChainMap(a.maps[0] | dict(b), *a.maps[1:]))
243-
a |= b
244-
self.assertEqual(e, a)
236+
cm1 = ChainMap(dict(a=1, b=2), dict(c=3, d=4))
237+
cm2 = ChainMap(dict(a=10, e=5), dict(b=20, d=4))
238+
d = dict(a=10, c=30)
239+
pairs = [('a', 1), ('c',3)]
240+
241+
tmp = cm1 | cm2 # testing between chainmaps
242+
self.assertEqual(tmp, ChainMap(cm1.maps[0] | dict(cm2), *cm1.maps[1:]))
243+
cm1 |= cm2
244+
self.assertEqual(tmp, cm1)
245245

246-
f = b | c # testing between chainmap and mapping
247-
self.assertEqual(f, ChainMap(b.maps[0] | c, *b.maps[1:]))
248-
g = c | b
249-
self.assertEqual(g, ChainMap(c | dict(b)))
250-
b |= c
251-
self.assertEqual(f, b)
246+
tmp = cm2 | d # testing between chainmap and mapping
247+
self.assertEqual(tmp, ChainMap(cm2.maps[0] | d, *cm2.maps[1:]))
248+
self.assertEqual(d | cm2, ChainMap(d | dict(cm2)))
249+
cm2 |= d
250+
self.assertEqual(tmp, cm2)
252251

253252
# testing behavior between chainmap and iterable key-value pairs
254253
with self.assertRaises(TypeError):
255-
a | d
256-
a |= d
257-
self.assertEqual(a, ChainMap(a.maps[0] | dict(d)), *a.maps[1:])
254+
cm1 | pairs
255+
cm1 |= pairs
256+
self.assertEqual(cm1, ChainMap(cm1.maps[0] | dict(pairs)), *cm1.maps[1:])
258257

259258

260259
################################################################################

0 commit comments

Comments
 (0)