Let the exceptions propagate

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Author: DinoV

Lib/asyncio/taskgroups.py

@@ -159,7 +159,10 @@ def create_task(self, coro, *, name=None, context=None):
         self._tasks.add(task)
         return task
 
-    def _eager_eval(self, coro):
+    def enqueue(self, coro, no_future=True):
+        if not self._entered:
+            raise RuntimeError(f"TaskGroup {self!r} has not been entered")
+
         try:
             fut = coro.send(None)
             task = self.create_task(coro)
@@ -168,23 +171,8 @@ def _eager_eval(self, coro):
         except StopIteration as e:
             # The co-routine has completed synchronously and we've got
             # our result.
-            return PyCoroEagerResult(e.args[0] if e.args else None)
-        except Exception as e:
             res = Future(loop=self._loop)
-            res.set_exception(e)
-            return res
-
-    def enqueue(self, coro, no_future=True):
-        if not self._entered:
-            raise RuntimeError(f"TaskGroup {self!r} has not been entered")
-
-        res = self._eager_eval(coro)
-        if isinstance(res, PyCoroEagerResult):
-            if not no_future:
-                fut = Future(loop=self._loop)
-                fut.set_result(res.value)
-                return fut
-        else:
+            res.set_result(e.args[0] if e.args else None)
             return res
 
     # Since Python 3.8 Tasks propagate all exceptions correctly,

Lib/test/test_asyncio/test_taskgroups.py

@@ -753,6 +753,16 @@ async def eager2():
         self.assertEqual(t1.result(), 42)
         self.assertEqual(t2.result(), 11)
 
+    async def test_taskgroup_enqueue_exception(self):
+        async def foo1():
+            1 / 0
+
+        with self.assertRaises(ExceptionGroup) as cm:
+            async with taskgroups.TaskGroup() as g:
+                g.enqueue(foo1())
+
+        self.assertEqual(get_error_types(cm.exception), {ZeroDivisionError})
+
     async def test_taskgroup_fanout_task(self):
         async def step(i):
             if i == 0: