bpo-38962: Fix reference leak in new_interpreter() (GH-17453)

pablogsal · miss-islington · commit b96c6b0723b8 · 2019-12-04T03:19:59.000-08:00
https://bugs.python.org/issue38962 Automerge-Triggered-By: @pablogsal
diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
@@ -648,9 +648,11 @@ pycore_init_builtins(PyThreadState *tstate)
     if (interp->builtins_copy == NULL) {
         goto error;
     }
+    Py_DECREF(bimod);
     return _PyStatus_OK();
 
 error:
+    Py_XDECREF(bimod);
     return _PyStatus_ERR("can't initialize builtins module");
 }
 

Original file line number	Diff line number	Diff line change
`@@ -648,9 +648,11 @@ pycore_init_builtins(PyThreadState *tstate)`
`648`	`648`	`if (interp->builtins_copy == NULL) {`
`649`	`649`	`goto error;`
`650`	`650`	`}`
	`651`	`+ Py_DECREF(bimod);`
`651`	`652`	`return _PyStatus_OK();`
`652`	`653`
`653`	`654`	`error:`
	`655`	`+ Py_XDECREF(bimod);`
`654`	`656`	`return _PyStatus_ERR("can't initialize builtins module");`
`655`	`657`	`}`
`656`	`658`