Skip to content

Commit

Permalink
gh-104146: Purge dead code from Argument Clinic (#104680)
Browse files Browse the repository at this point in the history
The following local variables were assigned but never used:

- line 551:  result
- line 1341: groups
- line 1431: default_return_converter
- line 1529: ignore_self
- line 1809: input_checksum
- line 4224: new'

---

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
  • Loading branch information
erlend-aasland and AlexWaygood authored May 20, 2023
1 parent 02b6003 commit ae147d0
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions Tools/clinic/clinic.py
Original file line number Diff line number Diff line change
Expand Up @@ -548,8 +548,6 @@ def permute_optional_groups(left, required, right):
If required is empty, left must also be empty.
"""
required = tuple(required)
result = []

if not required:
if left:
raise ValueError("required is empty but left is not")
Expand Down Expand Up @@ -1338,7 +1336,6 @@ def render_option_group_parsing(self, f, template_dict):
if isinstance(parameters[0].converter, self_converter):
del parameters[0]

groups = []
group = None
left = []
right = []
Expand Down Expand Up @@ -1428,8 +1425,6 @@ def render_function(self, clinic, f):
first_optional = len(selfless)
positional = selfless and selfless[-1].is_positional_only()
new_or_init = f.kind in (METHOD_NEW, METHOD_INIT)
default_return_converter = (not f.return_converter or
f.return_converter.type == 'PyObject *')
has_option_groups = False

# offset i by -1 because first_optional needs to ignore self
Expand Down Expand Up @@ -1526,7 +1521,6 @@ def render_function(self, clinic, f):
template_dict['return_value'] = data.return_value

# used by unpack tuple code generator
ignore_self = -1 if isinstance(converters[0], self_converter) else 0
unpack_min = first_optional
unpack_max = len(selfless)
template_dict['unpack_min'] = str(unpack_min)
Expand Down Expand Up @@ -1803,10 +1797,8 @@ def is_stop_line(line):
if self.verify:
if 'input' in d:
checksum = d['output']
input_checksum = d['input']
else:
checksum = d['checksum']
input_checksum = None

computed = compute_checksum(output, len(checksum))
if checksum != computed:
Expand Down Expand Up @@ -4243,8 +4235,7 @@ def directive_version(self, required):
fail("Insufficient Clinic version!\n Version: " + version + "\n Required: " + required)

def directive_module(self, name):
fields = name.split('.')
new = fields.pop()
fields = name.split('.')[:-1]
module, cls = self.clinic._module_and_class(fields)
if cls:
fail("Can't nest a module inside a class!")
Expand Down

0 comments on commit ae147d0

Please sign in to comment.