Skip to content

Commit 902bb62

Browse files
bpo-33205: dict: Change GROWTH_RATE to used*3 (GH-6350)
(cherry picked from commit 5fbc511) Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
1 parent ed12655 commit 902bb62

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
Change dict growth function from ``round_up_to_power_2(used*2+hashtable_size/2)`` to
2+
``round_up_to_power_2(used*3)``. Previously, dict is shrinked only when ``used == 0``.
3+
Now dict has more chance to be shrinked.

Objects/dictobject.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -396,17 +396,16 @@ dk_set_index(PyDictKeysObject *keys, Py_ssize_t i, Py_ssize_t ix)
396396
*/
397397

398398
/* GROWTH_RATE. Growth rate upon hitting maximum load.
399-
* Currently set to used*2 + capacity/2.
399+
* Currently set to used*3.
400400
* This means that dicts double in size when growing without deletions,
401401
* but have more head room when the number of deletions is on a par with the
402-
* number of insertions.
403-
* Raising this to used*4 doubles memory consumption depending on the size of
404-
* the dictionary, but results in half the number of resizes, less effort to
405-
* resize.
402+
* number of insertions. See also bpo-17563 and bpo-33205.
403+
*
406404
* GROWTH_RATE was set to used*4 up to version 3.2.
407405
* GROWTH_RATE was set to used*2 in version 3.3.0
406+
* GROWTH_RATE was set to used*2 + capacity/2 in 3.4.0-3.6.0.
408407
*/
409-
#define GROWTH_RATE(d) (((d)->ma_used*2)+((d)->ma_keys->dk_size>>1))
408+
#define GROWTH_RATE(d) ((d)->ma_used*3)
410409

411410
#define ENSURE_ALLOWS_DELETIONS(d) \
412411
if ((d)->ma_keys->dk_lookup == lookdict_unicode_nodummy) { \

0 commit comments

Comments
 (0)