Address review comments

Author: Nico-Posada

Lib/test/test_asyncio/test_tasks.py

@@ -2689,20 +2689,27 @@ def test_get_context(self):
             loop.close()
 
     def test_proper_refcounts(self):
+        # see: https://github.com/python/cpython/issues/126083
         class Break:
             def __str__(self):
-                raise Exception("break")
+                raise RuntimeError("break")
 
         obj = object()
         initial_refcount = sys.getrefcount(obj)
 
         coro = coroutine_function()
+        loop = asyncio.new_event_loop()
         task = asyncio.Task.__new__(asyncio.Task)
 
-        for _ in range(10000):
+        for _ in range(5):
             try:
-                task.__init__(coro, context=obj, name=Break())
-            except: pass
+                task.__init__(coro, loop=loop, context=obj, name=Break())
+            except Exception as e:
+                # exception should only come from Break.__str__ as it's used to
+                # avoid having to do too much setup for this test
+                self.assertIs(type(e), RuntimeError)
+                self.assertEqual(e.args[0], "break")
+        coro.close()
         del task
 
         self.assertEqual(sys.getrefcount(obj), initial_refcount)

Misc/NEWS.d/next/Library/2024-10-28-22-35-22.gh-issue-126083.TuI--n.rst

@@ -1,2 +1 @@
-Fixed a reference leak that would happen in asyncio tasks when you would
-reinitialize your task object with a non-None context.
+Fixed a reference leak in :class:`asyncio.Task` objects when reinitializing the same object with a non-``None`` context. Patch by Nico Posada.