Skip to content

Commit 89ecd25

Browse files
committed
bpo-40077: Apply Victor's review
1 parent 043590b commit 89ecd25

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

Modules/_bz2module.c

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,9 @@ BZ2_Free(void* ctx, void *ptr)
305305
PyMem_RawFree(ptr);
306306
}
307307

308-
// TODO: Convert it to clinic
308+
309+
/* Argument Clinic is not used since the Argument Clinic always want to
310+
check the type which would be wrong here */
309311
static int
310312
_bz2_BZ2Compressor___init___impl(BZ2Compressor *self, int compresslevel)
311313
{
@@ -415,7 +417,7 @@ static PyType_Spec bz2_compressor_type_spec = {
415417
.name = "_bz2.BZ2Compressor",
416418
.basicsize = sizeof(BZ2Compressor),
417419
// Calling PyType_GetModuleState() on a subclass is not safe.
418-
// dbmtype_spec does not have Py_TPFLAGS_BASETYPE flag
420+
// bz2_compressor_type_spec does not have Py_TPFLAGS_BASETYPE flag
419421
// which prevents to create a subclass.
420422
// So calling PyType_GetModuleState() in this file is always safe.
421423
.flags = Py_TPFLAGS_DEFAULT,
@@ -655,7 +657,8 @@ _bz2_BZ2Decompressor___reduce___impl(BZ2Decompressor *self)
655657
return NULL;
656658
}
657659

658-
// TODO: Convert it to clinic
660+
/* Argument Clinic is not used since the Argument Clinic always want to
661+
check the type which would be wrong here */
659662
static int
660663
_bz2_BZ2Decompressor___init___impl(BZ2Decompressor *self)
661664
{
@@ -781,7 +784,7 @@ static PyType_Spec bz2_decompressor_type_spec = {
781784
.name = "_bz2.BZ2Decompressor",
782785
.basicsize = sizeof(BZ2Decompressor),
783786
// Calling PyType_GetModuleState() on a subclass is not safe.
784-
// dbmtype_spec does not have Py_TPFLAGS_BASETYPE flag
787+
// bz2_decompressor_type_spec does not have Py_TPFLAGS_BASETYPE flag
785788
// which prevents to create a subclass.
786789
// So calling PyType_GetModuleState() in this file is always safe.
787790
.flags = Py_TPFLAGS_DEFAULT,

0 commit comments

Comments
 (0)