Skip to content

Commit 80b2b88

Browse files
authored
Fix "lazy from (...) import (...)" tests (#145213)
1 parent 017ccd3 commit 80b2b88

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
import importlib
1+
import sys
22

33
def filter(module_name, imported_name, from_list):
44
assert module_name == __name__
55
assert imported_name == "test.test_import.data.lazy_imports.basic2"
6-
assert from_list == ['f']
6+
assert from_list == ('f',)
77
return False
88

9-
importlib.set_lazy_imports(None, filter)
9+
sys.set_lazy_imports_filter(filter)
1010

11-
lazy from import test.test_import.data.lazy_imports.basic2 import f
11+
lazy from test.test_import.data.lazy_imports.basic2 import f
Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
1-
import importlib
1+
import sys
22

33
def filter(module_name, imported_name, from_list):
44
assert module_name == __name__
55
assert imported_name == "test.test_import.data.lazy_imports.basic2"
6-
assert from_list == ['f']
6+
assert from_list == ('f',)
77
return True
88

9-
importlib.set_lazy_imports(None, filter)
9+
sys.set_lazy_imports("normal")
10+
sys.set_lazy_imports_filter(filter)
1011

11-
lazy from import test.test_import.data.lazy_imports.basic2 import f
12+
lazy from test.test_import.data.lazy_imports.basic2 import f

Lib/test/test_import/test_lazy_imports.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,12 +119,12 @@ def test_global_filter_true(self):
119119

120120
def test_global_filter_from(self):
121121
"""Filter should work with 'from' imports."""
122-
import test.test_import.data.lazy_imports.global_filter
122+
import test.test_import.data.lazy_imports.global_filter_from
123123
self.assertIn("test.test_import.data.lazy_imports.basic2", sys.modules)
124124

125125
def test_global_filter_from_true(self):
126126
"""Filter returning True should allow lazy 'from' imports."""
127-
import test.test_import.data.lazy_imports.global_filter_true
127+
import test.test_import.data.lazy_imports.global_filter_from_true
128128
self.assertNotIn("test.test_import.data.lazy_imports.basic2", sys.modules)
129129

130130

0 commit comments

Comments
 (0)