gh-91731: Don't define 'static_assert' in C++11 where is a keyword to avoid UB (GH-93700)

miss-islington · pablogsal · web-flow · commit 74561095d906 · 2022-06-16T07:50:15.000-07:00
(cherry picked from commit 65ff27c) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
diff --git a/Include/pymacro.h b/Include/pymacro.h
@@ -12,8 +12,10 @@
 
 // static_assert is defined in glibc from version 2.16. Before it requires
 // compiler support (gcc >= 4.6) and is called _Static_assert.
+// In C++ 11 static_assert is a keyword, redefining is undefined behaviour.
 #if (defined(__GLIBC__) \
      && (__GLIBC__ < 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ <= 16)) \
+     && !(defined(__cplusplus) && __cplusplus >= 201103L) \
      && !defined(static_assert))
 #  define static_assert _Static_assert
 #endif
diff --git a/Misc/NEWS.d/next/C API/2022-06-10-23-41-48.gh-issue-91731.fhYUQG.rst b/Misc/NEWS.d/next/C API/2022-06-10-23-41-48.gh-issue-91731.fhYUQG.rst
@@ -0,0 +1,3 @@
+Avoid defining the ``static_assert`` when compiling with C++ 11, where this
+is a keyword and redefining it can lead to undefined behavior. Patch by
+Pablo Galindo

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+Avoid defining the ``static_assert`` when compiling with C++ 11, where this
	`2`	`+is a keyword and redefining it can lead to undefined behavior. Patch by`
	`3`	`+Pablo Galindo`