GH-95045: gc untrack _lsprof.Profiler before deallocating it (GH-95315)

miss-islington · kumaraditya303 · web-flow · commit 6b01fc7045df · 2022-07-27T05:37:43.000-07:00
Automerge-Triggered-By: GH:pablogsal (cherry picked from commit deacf39) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
diff --git a/Misc/NEWS.d/next/Library/2022-07-27-11-35-45.gh-issue-95045.iysT-Q.rst b/Misc/NEWS.d/next/Library/2022-07-27-11-35-45.gh-issue-95045.iysT-Q.rst
@@ -0,0 +1 @@
+Fix GC crash when deallocating ``_lsprof.Profiler`` by untracking it before calling any callbacks. Patch by Kumar Aditya.
diff --git a/Modules/_lsprof.c b/Modules/_lsprof.c
@@ -747,6 +747,7 @@ profiler_traverse(ProfilerObject *op, visitproc visit, void *arg)
 static void
 profiler_dealloc(ProfilerObject *op)
 {
+    PyObject_GC_UnTrack(op);
     if (op->flags & POF_ENABLED) {
         PyThreadState *tstate = _PyThreadState_GET();
         if (_PyEval_SetProfile(tstate, NULL, NULL) < 0) {

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix GC crash when deallocating ``_lsprof.Profiler`` by untracking it before calling any callbacks. Patch by Kumar Aditya.
Original file line number	Diff line number	Diff line change
`@@ -747,6 +747,7 @@ profiler_traverse(ProfilerObject op, visitproc visit, void arg)`
`747`	`747`	`static void`
`748`	`748`	`profiler_dealloc(ProfilerObject *op)`
`749`	`749`	`{`
	`750`	`+ PyObject_GC_UnTrack(op);`
`750`	`751`	`if (op->flags & POF_ENABLED) {`
`751`	`752`	`PyThreadState *tstate = _PyThreadState_GET();`
`752`	`753`	`if (_PyEval_SetProfile(tstate, NULL, NULL) < 0) {`