style nits

Author: nascheme

Lib/distutils/tests/test_dist.py

@@ -368,10 +368,11 @@ def test_classifier(self):
     def test_classifier_invalid_type(self):
         attrs = {'name': 'Boa', 'version': '3.0',
                  'classifiers': ('Programming Language :: Python :: 3',)}
-        msg = "should be a list"
         with captured_stderr() as error:
             d = Distribution(attrs)
-        self.assertIn(msg, error.getvalue())
+        # should have warning about passing a non-list
+        self.assertIn('should be a list', error.getvalue())
+        # should be converted to a list
         self.assertIsInstance(d.metadata.classifiers, list)
         self.assertEqual(d.metadata.classifiers,
                          list(attrs['classifiers']))
@@ -386,10 +387,11 @@ def test_keywords(self):
     def test_keywords_invalid_type(self):
         attrs = {'name': 'Monty', 'version': '1.0',
                  'keywords': ('spam', 'eggs', 'life of brian')}
-        msg = "should be a list"
         with captured_stderr() as error:
             d = Distribution(attrs)
-        self.assertIn(msg, error.getvalue())
+        # should have warning about passing a non-list
+        self.assertIn('should be a list', error.getvalue())
+        # should be converted to a list
         self.assertIsInstance(d.metadata.keywords, list)
         self.assertEqual(d.metadata.keywords, list(attrs['keywords']))
 
@@ -403,10 +405,11 @@ def test_platforms(self):
     def test_platforms_invalid_types(self):
         attrs = {'name': 'Monty', 'version': '1.0',
                  'platforms': ('GNU/Linux', 'Some Evil Platform')}
-        msg = "should be a list"
         with captured_stderr() as error:
             d = Distribution(attrs)
-        self.assertIn(msg, error.getvalue())
+        # should have warning about passing a non-list
+        self.assertIn('should be a list', error.getvalue())
+        # should be converted to a list
         self.assertIsInstance(d.metadata.platforms, list)
         self.assertEqual(d.metadata.platforms, list(attrs['platforms']))