Simply invalidate cache

corona10 · corona10 · commit 5eb2b1305376 · 2023-07-23T22:51:28.000+09:00
diff --git a/Modules/_dbmmodule.c b/Modules/_dbmmodule.c
@@ -430,6 +430,8 @@ _dbm_dbm_clear_impl(dbmobject *self, PyTypeObject *cls)
     assert(state != NULL);
     check_dbmobject_open(self, state->dbm_error);
     datum key;
+    // Invalidate cache
+    self->di_size = -1;
     while (1) {
         key = dbm_firstkey(self->di_dbm);
         if (key.dptr == NULL) {
@@ -440,9 +442,6 @@ _dbm_dbm_clear_impl(dbmobject *self, PyTypeObject *cls)
             PyErr_SetString(state->dbm_error, "cannot delete item from database");
             return NULL;
         }
-        if (self->di_size > 0) {
-            self->di_size--;
-        }
     }
     Py_RETURN_NONE;
 }

Original file line number	Diff line number	Diff line change
`@@ -430,6 +430,8 @@ _dbm_dbm_clear_impl(dbmobject self, PyTypeObject cls)`
`430`	`430`	`assert(state != NULL);`
`431`	`431`	`check_dbmobject_open(self, state->dbm_error);`
`432`	`432`	`datum key;`
	`433`	`+ // Invalidate cache`
	`434`	`+ self->di_size = -1;`
`433`	`435`	`while (1) {`
`434`	`436`	`key = dbm_firstkey(self->di_dbm);`
`435`	`437`	`if (key.dptr == NULL) {`
`@@ -440,9 +442,6 @@ _dbm_dbm_clear_impl(dbmobject self, PyTypeObject cls)`
`440`	`442`	`PyErr_SetString(state->dbm_error, "cannot delete item from database");`
`441`	`443`	`return NULL;`
`442`	`444`	`}`
`443`		`- if (self->di_size > 0) {`
`444`		`- self->di_size--;`
`445`		`- }`
`446`	`445`	`}`
`447`	`446`	`Py_RETURN_NONE;`
`448`	`447`	`}`