Skip to content

Commit 4e147ca

Browse files
authored
[3.13] Revert "[3.13] gh-69214: Fix fcntl.ioctl() request type (GH-119498) (… (#119906)
Revert "[3.13] gh-69214: Fix fcntl.ioctl() request type (GH-119498) (#119504)" This reverts commit 0bab0b3. The change modified how negative values, like termios.TIOCSWINSZ, was treated and is actually backward incompatible.
1 parent 48054d2 commit 4e147ca

File tree

3 files changed

+8
-12
lines changed

3 files changed

+8
-12
lines changed

Misc/NEWS.d/next/Library/2024-05-24-11-47-08.gh-issue-69214.Grl6zF.rst

-3
This file was deleted.

Modules/clinic/fcntlmodule.c.h

+5-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Modules/fcntlmodule.c

+3-3
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ fcntl_fcntl_impl(PyObject *module, int fd, int code, PyObject *arg)
112112
fcntl.ioctl
113113
114114
fd: fildes
115-
request as code: unsigned_long(bitwise=True)
115+
request as code: unsigned_int(bitwise=True)
116116
arg as ob_arg: object(c_default='NULL') = 0
117117
mutate_flag as mutate_arg: bool = True
118118
/
@@ -148,9 +148,9 @@ code.
148148
[clinic start generated code]*/
149149

150150
static PyObject *
151-
fcntl_ioctl_impl(PyObject *module, int fd, unsigned long code,
151+
fcntl_ioctl_impl(PyObject *module, int fd, unsigned int code,
152152
PyObject *ob_arg, int mutate_arg)
153-
/*[clinic end generated code: output=3d8eb6828666cea1 input=cee70f6a27311e58]*/
153+
/*[clinic end generated code: output=7f7f5840c65991be input=967b4a4cbeceb0a8]*/
154154
{
155155
#define IOCTL_BUFSZ 1024
156156
/* We use the unsigned non-checked 'I' format for the 'code' parameter

0 commit comments

Comments
 (0)