Skip to content

Commit

Permalink
gh-119050: Add type hints to libregrtest/results.py (#119144)
Browse files Browse the repository at this point in the history
Sort also 'omitted' in TestResults.display_result().
  • Loading branch information
vstinner authored May 18, 2024
1 parent c141d43 commit 30b4e9f
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions Lib/test/libregrtest/results.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@


class TestResults:
def __init__(self):
def __init__(self) -> None:
self.bad: TestList = []
self.good: TestList = []
self.rerun_bad: TestList = []
Expand All @@ -38,22 +38,22 @@ def __init__(self):
# used by -T with -j
self.covered_lines: set[Location] = set()

def is_all_good(self):
def is_all_good(self) -> bool:
return (not self.bad
and not self.skipped
and not self.interrupted
and not self.worker_bug)

def get_executed(self):
def get_executed(self) -> set[TestName]:
return (set(self.good) | set(self.bad) | set(self.skipped)
| set(self.resource_denied) | set(self.env_changed)
| set(self.run_no_tests))

def no_tests_run(self):
def no_tests_run(self) -> bool:
return not any((self.good, self.bad, self.skipped, self.interrupted,
self.env_changed))

def get_state(self, fail_env_changed):
def get_state(self, fail_env_changed: bool) -> str:
state = []
if self.bad:
state.append("FAILURE")
Expand Down Expand Up @@ -204,7 +204,7 @@ def display_result(self, tests: TestTuple, quiet: bool, print_slowest: bool):
omitted = set(tests) - self.get_executed()

# less important
all_tests.append((omitted, "test", "{} omitted:"))
all_tests.append((sorted(omitted), "test", "{} omitted:"))
if not quiet:
all_tests.append((self.skipped, "test", "{} skipped:"))
all_tests.append((self.resource_denied, "test", "{} skipped (resource denied):"))
Expand Down

0 comments on commit 30b4e9f

Please sign in to comment.