gh-111259: Optimize recursive wildcards in pathlib (GH-111303)

Regular expression pattern `(?s:.)` is much faster than `[\s\S]`.
python · Oct 26, 2023 · 309efb3 · 309efb3
1 parent 67a91f7
commit 309efb3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/Lib/pathlib.py b/Lib/pathlib.py
@@ -124,13 +124,13 @@ def _compile_pattern_lines(pattern_lines, case_sensitive):
         elif part == '*':
             part = r'.+'
         elif part == '**\n':
-            # '**/' component: we use '[\s\S]' rather than '.' so that path
+            # '**/' component: we use '(?s:.)' rather than '.' so that path
             # separators (i.e. newlines) are matched. The trailing '^' ensures
             # we terminate after a path separator (i.e. on a new line).
-            part = r'[\s\S]*^'
+            part = r'(?s:.)*^'
         elif part == '**':
             # '**' component.
-            part = r'[\s\S]*'
+            part = r'(?s:.)*'
         elif '**' in part:
             raise ValueError("Invalid pattern: '**' can only be an entire path component")
         else:

diff --git a/Misc/NEWS.d/next/Library/2023-10-25-11-13-35.gh-issue-111259.z7ndeA.rst b/Misc/NEWS.d/next/Library/2023-10-25-11-13-35.gh-issue-111259.z7ndeA.rst
@@ -0,0 +1 @@
+Optimize recursive wildcards in :mod:`pathlib`.